fix(process-email-test): add tests cases with no email

* add test case with no email * update excludes * add test logic * Update processEmails.test.ts * Update stateSubmitters.ts
Enterprise-CMCS · Feb 5, 2025 · 93fe423 · 93fe423
1 parent 3ea942a
commit 93fe423
Show file tree

Hide file tree

Showing 3 changed files with 95 additions and 44 deletions.
diff --git a/lib/libs/email/content/withdrawConfirmation/index.tsx b/lib/libs/email/content/withdrawConfirmation/index.tsx
@@ -3,57 +3,32 @@ import { AuthoritiesWithUserTypesTemplate } from "../..";
 import { ChipSpaStateEmail, MedSpaStateEmail, WaiverStateEmail } from "./emailTemplates";
 import { render } from "@react-email/render";
 
+const generateWithdrawEmail = async (
+  variables: Events["WithdrawPackage"] & CommonEmailVariables & { emails: EmailAddresses },
+  subjectPrefix: string,
+  EmailComponent: React.FC<{ variables: any }>,
+) => {
+  return {
+    to: variables.allStateUsersEmails?.length
+      ? variables.allStateUsersEmails
+      : [`${variables.submitterName} <${variables.submitterEmail}>`],
+    subject: `${subjectPrefix} ${variables.id} Withdrawal Confirmation`,
+    body: await render(<EmailComponent variables={variables} />),
+  };
+};
+
 export const withdrawConfirmation: AuthoritiesWithUserTypesTemplate = {
   [Authority.MED_SPA]: {
-    state: async (
-      variables: Events["WithdrawPackage"] & CommonEmailVariables & { emails: EmailAddresses },
-    ) => {
-      return {
-        to: variables.allStateUsersEmails?.length
-          ? variables.allStateUsersEmails
-          : [`${variables.submitterName} <${variables.submitterEmail}>`],
-        subject: `Medicaid SPA Package ${variables.id} Withdrawal Confirmation`,
-        body: await render(<MedSpaStateEmail variables={variables} />),
-      };
-    },
+    state: (variables) =>
+      generateWithdrawEmail(variables, "Medicaid SPA Package", MedSpaStateEmail),
   },
   [Authority.CHIP_SPA]: {
-    state: async (
-      variables: Events["WithdrawPackage"] & CommonEmailVariables & { emails: EmailAddresses },
-    ) => {
-      return {
-        to: variables.allStateUsersEmails?.length
-          ? variables.allStateUsersEmails
-          : [`${variables.submitterName} <${variables.submitterEmail}>`],
-        subject: `CHIP SPA Package ${variables.id} Withdraw Confirmation`,
-        body: await render(<ChipSpaStateEmail variables={variables} />),
-      };
-    },
+    state: (variables) => generateWithdrawEmail(variables, "CHIP SPA Package", ChipSpaStateEmail),
   },
   [Authority["1915b"]]: {
-    state: async (
-      variables: Events["WithdrawPackage"] & CommonEmailVariables & { emails: EmailAddresses },
-    ) => {
-      return {
-        to: variables.allStateUsersEmails?.length
-          ? variables.allStateUsersEmails
-          : [`${variables.submitterName} <${variables.submitterEmail}>`],
-        subject: `1915(b) ${variables.id} Withdrawal Confirmation`,
-        body: await render(<WaiverStateEmail variables={variables} />),
-      };
-    },
+    state: (variables) => generateWithdrawEmail(variables, "1915(b)", WaiverStateEmail),
   },
   [Authority["1915c"]]: {
-    state: async (
-      variables: Events["WithdrawPackage"] & CommonEmailVariables & { emails: EmailAddresses },
-    ) => {
-      return {
-        to: variables.allStateUsersEmails?.length
-          ? variables.allStateUsersEmails
-          : [`${variables.submitterName} <${variables.submitterEmail}>`],
-        subject: `1915(c) ${variables.id} Withdrawal Confirmation`,
-        body: await render(<WaiverStateEmail variables={variables} />),
-      };
-    },
+    state: (variables) => generateWithdrawEmail(variables, "1915(c)", WaiverStateEmail),
   },
 };
diff --git a/lib/libs/email/getAllStateUsers.test.ts b/lib/libs/email/getAllStateUsers.test.ts
@@ -31,4 +31,14 @@ describe("getAllStateUsers", () => {
     const result = await getAllStateUsers({ userPoolId: USER_POOL_ID, state: "MA" });
     expect(result).toEqual([]);
   });
+
+  it("should ignore users with no email", async () => {
+    const result = await getAllStateUsers({ userPoolId: USER_POOL_ID, state: "AK" });
+    expect(result).toEqual([]);
+  });
+
+  it("should ignore users with invalid email formats", async () => {
+    const result = await getAllStateUsers({ userPoolId: USER_POOL_ID, state: "LA" });
+    expect(result).toEqual([]);
+  });
 });
diff --git a/mocks/data/users/stateSubmitters.ts b/mocks/data/users/stateSubmitters.ts
@@ -306,6 +306,70 @@ export const testNewStateSubmitter: TestUserData = {
   Username: "f8e64f73-d121-4252-b9e3-1f4df902a1c1",
 };
 
+export const noEmailStateSubmitter: TestUserData = {
+  UserAttributes: [
+    {
+      Name: "email",
+      Value: "bademail-",
+    },
+    {
+      Name: "email_verified",
+      Value: "true",
+    },
+    {
+      Name: "given_name",
+      Value: "Test",
+    },
+    {
+      Name: "family_name",
+      Value: "Submitter",
+    },
+    {
+      Name: "custom:state",
+      Value: "LA",
+    },
+    {
+      Name: "custom:cms-roles",
+      Value: "onemac-micro-statesubmitter",
+    },
+    {
+      Name: "sub",
+      Value: "f8e64f73-d121-4252-b9e3-1f4df902a1c2",
+    },
+  ],
+  Username: "f8e64f73-d121-4252-b9e3-1f4df902a1c2",
+};
+
+export const invalidEmailStateSubmitter: TestUserData = {
+  UserAttributes: [
+    {
+      Name: "email_verified",
+      Value: "true",
+    },
+    {
+      Name: "given_name",
+      Value: "Test",
+    },
+    {
+      Name: "family_name",
+      Value: "Submitter",
+    },
+    {
+      Name: "custom:state",
+      Value: "AK",
+    },
+    {
+      Name: "custom:cms-roles",
+      Value: "onemac-micro-statesubmitter",
+    },
+    {
+      Name: "sub",
+      Value: "f8e64f73-d121-4252-b9e3-1f4df902a1c2",
+    },
+  ],
+  Username: "f8e64f73-d121-4252-b9e3-1f4df902a1c2",
+};
+
 export const stateSubmitters: TestUserData[] = [
   makoStateSubmitter,
   superUser,
@@ -316,4 +380,6 @@ export const stateSubmitters: TestUserData[] = [
   noStateSubmitter,
   automatedStateSubmitter,
   testNewStateSubmitter,
+  noEmailStateSubmitter,
+  invalidEmailStateSubmitter,
 ];