Download release binary #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/index.ts
Outdated
| const artifact = artifacts.find( | ||
| (a) => a.goos === goOs && a.goarch === goArch | ||
| const asset = validRelease.assets.find( | ||
| (a) => a.name.includes(nodeArch) && a.name.includes(nodeType) |
There was a problem hiding this comment.
you should be able to just construct the expected binary name and check for an exact match right? that seems a little more straightforward and less likely to lead to something weird happening
ben-harvey
force-pushed
the
bharvey-get-releases
branch
from
e6bd2ad to
640f4a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the action code to download the correct release binary from our dedicated release repo at https://github.com/Enterprise-CMCS/mac-fc-report-event-releases. It adds a
versioninput that uses semver to parse the input, and atokeninput that uses theGITHUB_TOKENas its default. This lets us get around the low rate limit imposed by the GitHub API on unauthenticated requests.Testing:
test-actionworkflow