Skip to content

Commit

Permalink
changes for review
Browse files Browse the repository at this point in the history
  • Loading branch information
ben-harvey committed Apr 25, 2024
1 parent d894cc3 commit 2b7869f
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
7 changes: 6 additions & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,10 @@ runs:

- name: Assume DSO metrics reporting role
id: assume-dso-role
if: ${{ !cancelled() && steps.run-command.outputs.start-time != '' }}
if: |
!cancelled() &&
steps.run-command.outputs.start-time != '' &&
(inputs.oidc-role != '' && steps.get-oidc-creds.outcome == 'success')
continue-on-error: true
uses: aws-actions/configure-aws-credentials@v4
with:
Expand All @@ -85,6 +88,7 @@ runs:
if: |
!cancelled() &&
steps.run-command.outputs.start-time != '' &&
steps.assume-dso-role.outcome == 'success' &&
inputs.event-type == 'test'
continue-on-error: true
uses: Enterprise-CMCS/mac-fc-report-dso-event/.github/actions/[email protected]
Expand All @@ -111,6 +115,7 @@ runs:
if: |
!cancelled() &&
steps.run-command.outputs.start-time != '' &&
steps.assume-dso-role.outcome == 'success' &&
inputs.event-type == 'deploy'
continue-on-error: true
uses: Enterprise-CMCS/mac-fc-report-dso-event/.github/actions/[email protected]
Expand Down
4 changes: 2 additions & 2 deletions build/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -32239,9 +32239,9 @@ function main() {
process.exit(1);
}
let returns;
const command = (0, os_1.type)() === windowsType ? `${releaseName}` : `./${releaseName}`;
const command = (0, os_1.type)() === windowsType ? `${releaseName} args` : `./${releaseName} args`;
try {
returns = (0, child_process_1.spawnSync)(command, [args], { shell: true });
returns = (0, child_process_1.spawnSync)(command, { shell: true });
}
catch (error) {
console.error(`Error spawning child process: ${error}`);
Expand Down
4 changes: 2 additions & 2 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ async function main() {

let returns;
const command =
type() === windowsType ? `${releaseName}` : `./${releaseName}`;
type() === windowsType ? `${releaseName} args` : `./${releaseName} args`;
try {
returns = spawnSync(command, [args], { shell: true });
returns = spawnSync(command, { shell: true });
} catch (error) {
console.error(`Error spawning child process: ${error}`);
process.exit(1);
Expand Down

0 comments on commit 2b7869f

Please sign in to comment.