-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EREGCSC-2746 -- Upgrade Vitest front end unit tests in key portions of the code #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
cgodwin1
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves EREGCSC-2746
Description
In support of our goal of 80% test coverage for all code in codebase, this Pull Request increases coverage in front end Javascript code in the form of unit tests written for Vitest.
This story's Acceptance Criteria specifically lists the following:
/solution/ui/regulations/utilities/
This pull request changes:
Increases Vitest unit test cases from 99 tests to 215 tests
Increases
/solution/ui/regulations/utilities/
test coverage to at least 80% for all coverage metricsIncreases overall front end Javascript test coverage
Steps to manually verify this change:
make test.vitest.ui