Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EREGCSC-2881 -- Remove redundant list on subject homepage #1494

Merged
merged 8 commits into from
Dec 4, 2024

Conversation

PhilR8
Copy link
Contributor

@PhilR8 PhilR8 commented Dec 2, 2024

Resolves EREGCSC-2881

Description

The Subjects list in the center of the Subject page, known as the "Table of Contents", is no longer needed: it duplicates the functionality of the Subjects Selector list that now exists in the left sidebar (see #1487).

This PR will remove the Table of Contents and replace it with copy text about how to use the Subjects page, which will be referred to as the "Subject Landing page".

This pull request changes:

  • Renames SubjectTOC.vue to SubjectLanding.vue
    • Removes Subject list
    • changes h1 heading to read "Find Policy Documents"
    • adds copy text (in the form of a ul) and link to /about/
    • Behavior about when Subject Landing page is shown is the same as before
  • Adds ability for user to reset all selected filters on Subjects page by clicking "Research a Subject" header link
    • Adds custom event link-clicked to Header Links that is emitted on click with current page name as payload
    • Adds event listener (via v-on directive's @ shorthand) in Subjects.vue that listens for this emitted event
    • On "Research a Subject" click, all query params are removed and Subject Landing page is shown
  • Removes bold font weight from left sidebar Subject subtitle on focus/hover
  • Tidies up focus and focus-visible outlines in Subject Selector and in a few buttons around the app

Steps to manually verify this change:

  1. Green check marks
  2. Visit /subjects/ on the experimental deployment
  3. Ensure that you see the Subject Landing page in the center of the page and not a duplicated list of subjects
  4. Add and remove subjects and other filters to ensure page works as expected
  5. When you have several filters selected, click "Research a Subject" at the top right of the header to reset all filters and once again show the Subject Landing page
  6. When hovering the cursor over the list of subjects in the left sidebar, no subject subtitle should have a bold style applied

Copy link

github-actions bot commented Dec 2, 2024

✨ See the Django Site in action

Copy link

github-actions bot commented Dec 3, 2024

✨ See the Django Site in action

Copy link

github-actions bot commented Dec 3, 2024

✨ See the Django Site in action

@PhilR8 PhilR8 marked this pull request as ready for review December 3, 2024 19:31
@PhilR8 PhilR8 requested a review from cgodwin1 as a code owner December 3, 2024 19:31
@PhilR8 PhilR8 added the Needs Review This PR needs a code review label Dec 3, 2024
Copy link
Contributor

@cgodwin1 cgodwin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cgodwin1 cgodwin1 added Approved and removed Needs Review This PR needs a code review labels Dec 4, 2024
@PhilR8 PhilR8 merged commit 4ed7562 into main Dec 4, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants