-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EREGCSC-2585 -- Update display of resources on site homepage #1458
Conversation
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
@@ -216,7 +216,7 @@ export default [ | |||
description: "SMDLs, SHOs, CIBs, FAQs, SMM", | |||
id: 4, | |||
is_fr_link_category: false, | |||
name: "Subregulatory Test Guidance", | |||
name: "Subregulatory Guidance", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was too clever by half and was screwing up the homepage tests. We need this to be Subregulatory Guidance in order to fetch the data from this fixture for the Recent Guidance tab
✨ See the Django Site in action ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Resolves EREGCSC-2585
Description
Updates the Recent Guidance/Rules tabs on the homepage.
This pull request changes:
pageSize
argument from3
to5
itemTitleLineLimit
injection key that is provided to all descendant components/subjects
page with the clicked subject selected/search
page when you click a Subject ChipSubjectChips.vue
component that is also used in the/search
and/subjects
pageSteps to manually verify this change:
/subjects
page with the correct subject selected on loadtext-overflow: ellipsis
style rule is applied