Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EREGCSC-2461 -- Use new category/subcategory model on repository #1161

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

PhilR8
Copy link
Contributor

@PhilR8 PhilR8 commented Feb 1, 2024

Resolves EREGCSC-2461

Description

Display new internal document categories and subcategories instead of internal Document Type when displaying internal documents on the Policy Repository. This will match how public resources are displayed.

This pull request changes:

  • Updates PolicyResults.vue logic to display category.name or category.parent.name instead of category.document_type.name.

Steps to manually verify this change:

  1. Visit the Policy Repository on the experimental deployment
  2. View internal docs and note the category labels above each internal result item
  3. Click through to a related citation and make sure the internal categories listed in the reader view's right sidebar match the category on the item when displayed in the Policy Repository

Copy link

github-actions bot commented Feb 1, 2024

✨ See the Django Site in action

Copy link

github-actions bot commented Feb 6, 2024

✨ See the Django Site in action

Copy link

github-actions bot commented Feb 6, 2024

✨ See the Django Site in action

Copy link

github-actions bot commented Feb 6, 2024

✨ See the Django Site in action

@PhilR8 PhilR8 marked this pull request as ready for review February 6, 2024 21:06
@PhilR8 PhilR8 added the Needs Review This PR needs a code review label Feb 6, 2024
Copy link
Contributor

@peggles2 peggles2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@peggles2 peggles2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@PhilR8 PhilR8 added Approved and removed Needs Review This PR needs a code review labels Feb 7, 2024
@PhilR8 PhilR8 merged commit e586373 into main Feb 7, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants