Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EREGCSC-2519 -- Remove "View More" buttons on homepage #1157

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

PhilR8
Copy link
Contributor

@PhilR8 PhilR8 commented Jan 30, 2024

Resolves EREGCSC-2519

Description

On the homepage, under the "Recent Subregulatory Guidance" and "Recent Rules" tabs, we have "View More Guidance" and "View More Changes" buttons that go to the resources page (pre-filtered). We're working to retire the resources page, so let's remove these buttons.

This pull request changes:

  • Removes button markup and related props/methods from RecentResources Vue component
  • Updates Django template to no longer pass in unnecessary props
  • Updates homepage e2e test suite to assert that these buttons no longer exist

Steps to manually verify this change:

  1. Visit the experimental deployment
  2. Make sure there are no "View More" buttons at the bottom of the main content column

Copy link

✨ See the Django Site in action

@PhilR8 PhilR8 marked this pull request as ready for review January 30, 2024 14:58
@PhilR8 PhilR8 added the Needs Review This PR needs a code review label Jan 30, 2024
@PhilR8 PhilR8 added Approved and removed Needs Review This PR needs a code review labels Jan 30, 2024
@PhilR8 PhilR8 merged commit 43e1a78 into main Jan 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants