Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EREGCSC-2269 - New serverless invalidate package. #1110

Closed
wants to merge 6 commits into from
Closed

Conversation

thwalker6
Copy link
Contributor

@thwalker6 thwalker6 commented Dec 15, 2023

Resolves # EREGCSC-2269

Description-

Change serverless-cloudfront-invalidate to serverless-cf-invalidate-proxy

serverless-cf-invalidate-proxy is an npm package I created that is the same as invalidate but changes the proxy-agent from 5 to 6. 5 is what contained the package that was causing the issue. Cloud front invalidate has been sitting on the issue and multiple people report this on the github and no one answered. I merely took their package and made the change, and published it.

This pull request changes...

  • serverless-cf-invalidate-proxy is used now in place of serverless-cloudfront-invalidate to fix security issues.

Steps to manually verify this change...

  1. Site deploys correctly in experimental deploy.
  2. Look at the package-lock.json in the backend directory. vm2 is no longer being used.

Copy link

✨ See the Django Site in action

Copy link

✨ See the Django Site in action

Copy link

✨ See the Django Site in action

Copy link

✨ See the Django Site in action

Copy link

✨ See the Django Site in action

@thwalker6 thwalker6 changed the title EREGCSC-2269 EREGCSC-2269 - New serverless invalidate package. Dec 19, 2023
@peggles2 peggles2 added the Needs Review This PR needs a code review label Dec 19, 2023
@peggles2 peggles2 closed this Dec 20, 2023
@peggles2
Copy link
Contributor

Created a follow up ticket. https://jiraent.cms.gov/browse/EREGCSC-2478. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review This PR needs a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants