-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eregcsc 2290 edit button uploaded items #1051
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto EREGCSC-2290-edit-button-uploaded-items
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #EREGCSC-2290.
Description-
Uploaded files related to a subject should dislay an edit button if the user has appropriate jobcodes (Eregs-admin or Eregs-manager)
This pull request changes...
Backend:
solution/backend/content_search/serializers.py
Add an id to contentsearch serializer so that we can easily access the correct content on the admin panel.
solution/backend/content_search/urls.py
( route for the edit content search )
solution/backend/content_search/views.py
( create edit content view so that it determines which type of content you are looking at to route you to the correct part of the admin panel)
solution/backend/regulations/admin.py
Admin panel is updated so that when a user is created based on what jobcode they have they are assigned to designated user groups. These user groups will determine what access the user has.
solution/backend/regulations/views/policy_repository.py
determines if the user has editable job codes or not.
Frontend:
update the template to pass
has_editable_job_code
property to vue.jsCypress Tests:
solution/ui/e2e/cypress/e2e/policy-repository.spec.cy.js
tests the ui to see the edit button if user is an admin or manager.
Functional Tests:
(in progress) functional test.
tests the changes made in the admin interface.
Steps to manually verify this change...
None admin:
ADMIN:
Sign in through the admin panel.
click on users->click on the user name
scroll down to Groups and add yourself to eregs-reader
visit policy-repository?q=dental. notice that the listed files to the right have an edit option.