-
-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sponge module refactoring and fixes #2697
base: version/7.3.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I'm unsure that we actually want all the changes from MC to Sponge classes/methods. Given that most of the Sponge API is just implemented via mixin, the only thing this really accomplishes and pushing the we-sponge code base even further from we-fabric/we-neoforge (making it harder to maintain), and there's several places where sponge classes are just cast back to MC classes anyway.
If this PR just had the block/biome fixes and maybe even the event listener refactor (though see my comments), it would be a lot easier to pull, but right now I feel like there's too much that isn't necessarily a benefit.
worldedit-sponge/src/main/java/com/sk89q/worldedit/sponge/SpongeAdapter.java
Outdated
Show resolved
Hide resolved
worldedit-sponge/src/main/java/com/sk89q/worldedit/sponge/SpongeAdapter.java
Outdated
Show resolved
Hide resolved
worldedit-sponge/src/main/java/com/sk89q/worldedit/sponge/SpongeWorldEdit.java
Outdated
Show resolved
Hide resolved
In my opinion Sponge api is more "stable" than MC. |
Replace vanilla methods with sponge api when possible.
Fix items drop when making block changes.
Implement sendBiomeUpdates.
Move listeners into own class.
Cleanup dead code.