Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling for unsupported schematic files #2453

Merged
merged 2 commits into from
Dec 25, 2023
Merged

Improve error handling for unsupported schematic files #2453

merged 2 commits into from
Dec 25, 2023

Conversation

me4502
Copy link
Member

@me4502 me4502 commented Dec 24, 2023 •
edited
Loading

This PR does two things:

  • Unwraps an internal Schematic tag, to improve cross-version compatibility when reading schematic files (or ones that violate spec)
  • Prints the unsupported version error to the player, rather than as an IOException. This also means it now supports translation.

@me4502 me4502 marked this pull request as ready for review December 24, 2023 04:50
@me4502 me4502 requested a review from a team December 24, 2023 04:51
@me4502 me4502 requested a review from octylFractal December 25, 2023 03:40
@me4502 me4502 enabled auto-merge (squash) December 25, 2023 03:51
@me4502 me4502 merged commit 3295242 into version/7.2.x Dec 25, 2023
7 checks passed
@me4502 me4502 deleted the fix/improve-unsupported-schematic-error-handling branch December 25, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octylFractal octylFractal octylFractal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@me4502 @octylFractal