fix: correctly resolve deferred configuration when using manual ini…

…tialization mode fixes #102
EmmanuelRoux · Jan 3, 2025 · da82506 · da82506
1 parent 0e4a956
commit da82506
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/projects/ngx-matomo-client/core/tracker/matomo-initializer.service.ts b/projects/ngx-matomo-client/core/tracker/matomo-initializer.service.ts
@@ -76,6 +76,9 @@ export class MatomoInitializerService {
 
     if (isAutoConfigurationMode(this.config)) {
       this.injectMatomoScript(this.config);
+    } else {
+      // Mode is manual, immediately resolve deferred config
+      this.deferredConfig.markReady(this.config);
     }
   }, ALREADY_INITIALIZED_ERROR);
 

diff --git a/projects/ngx-matomo-client/form-analytics/matomo-form-analytics-initializer.service.spec.ts b/projects/ngx-matomo-client/form-analytics/matomo-form-analytics-initializer.service.spec.ts
@@ -158,14 +158,12 @@ describe('MatomoFormAnalyticsInitializer', () => {
     );
 
     // Then
-    // TODO change to expect error when #102 is fixed
-    await expectAsync(caughtError).toBePending();
-    // await expectAsync(caughtError).toBeResolvedTo(
-    //   new Error(
-    //     'Cannot resolve default matomo FormAnalytics plugin script url. ' +
-    //       'Please explicitly provide `loadScript` configuration property instead of `true`',
-    //   ),
-    // );
+    await expectAsync(caughtError).toBeResolvedTo(
+      new Error(
+        'Cannot resolve default matomo FormAnalytics plugin script url. ' +
+          'Please explicitly provide `loadScript` configuration property instead of `true`',
+      ),
+    );
     expectNoInjectedScript();
   });