Update Dockerfile to rust 1.84.0 #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Checklist * [x] I have read the [Contributor Guide](../../CONTRIBUTING.md) * [x] I have read and agree to the [Code of Conduct](../../CODE_OF_CONDUCT.md) * [x] I have added a description of my changes and why I'd like them included in the section below ### Description of Changes There is currently no way to override this rust version it seems as it doesn't seem to respect RUST_TOOLCHAIN env variable either... Problem is that I'm using already package resolver v3 and that is not possible unless it's running 1.84 or higher. Nightly would be an option as well of course ### Related Issues N/A
rust-toolchain.toml file does allow me to do this.. I wonder why RUST_TOOLCHAIN is not respected. either way this PR is not urgent, take your time |
1 task
I assume you mean Thanks a ton for taking the time! Have a nice day. |
GlenDC
added a commit
to plabayo/rama
that referenced
this pull request
Jan 11, 2025
as suggested by cargo-deny-action maintainer at EmbarkStudios/cargo-deny-action#86 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
There is currently no way to override this rust version it seems as it doesn't seem to respect RUST_TOOLCHAIN env variable either...
Problem is that I'm using already package resolver v3 and that is not possible unless it's running 1.84 or higher.
Nightly would be an option as well of course
Related Issues
N/A