separate out elementsd tests into separate crate; allow overriding the binaries #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
force-pushed
the
2023-03--elementsd
branch
from
93a6129 to
ba9487c
Compare
apoelstra
force-pushed
the
2023-03--elementsd
branch
from
ba9487c to
febf493
Compare
sanket1729
approved these changes
Apr 12, 2023
|
Looks like the test was ignored previously too? |
|
Right, looking at it. It is an elementsd bug. |
|
We can later update that test to test something else. |
|
Right I even had #110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need this to test this crate within Nix.