Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump nixpkgs and go version #291

Closed
wants to merge 1 commit into from

Conversation

grubles
Copy link
Collaborator

@grubles grubles commented Mar 29, 2024

This bumps go to 1.22 since 1.19 is EOL now.

This also updates the test daemons to:

cln v24.02.1
lnd v0.17.4-beta
bitcoin v26.0

@grubles
Copy link
Collaborator Author

grubles commented Mar 29, 2024

setup.go:113: lightingds[0].OpenChannel() FundChannel() 313:We would not have enough left for min-emergency-msat 25000sat

Anchor channels are now the default in >24.02. Looks like we need to account for the extra 25000 sat requirement now when opening a channel? @YusukeShimizu

@YusukeShimizu YusukeShimizu mentioned this pull request Apr 2, 2024
@YusukeShimizu
Copy link
Contributor

Yes, we need to account for the min-emergency-msat now when opening a channel.
I created another PR to ensure all tests are passed.
#292

@wtogami wtogami closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants