Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Assert crash in win64 native builds #1423

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Fix Assert crash in win64 native builds #1423

merged 2 commits into from
Feb 26, 2025

Conversation

psgreco
Copy link
Contributor

@psgreco psgreco commented Feb 25, 2025 •
edited
Loading

Not sure why this is not affecting linux builds too, but when fillBlindDetails adds the OP_RETURN, change_position still points to the old tx, we should update it to the new one.

Fixes 4 previously failing tests in win64.

feature_confidential_transactions.py --legacy-wallet
feature_issuance.py --legacy-wallet
wallet_basic.py --legacy-wallet
wallet_watchonly.py --legacy-wallet

@psgreco psgreco self-assigned this Feb 26, 2025
@psgreco psgreco requested review from delta1 and apoelstra February 26, 2025 01:51
@psgreco psgreco marked this pull request as ready for review February 26, 2025 01:52
delta1
delta1 approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 59c30c0

Ran tests locally on Linux

@delta1 delta1 merged commit df4e99d into ElementsProject:master Feb 26, 2025
13 checks passed
@psgreco psgreco deleted the master-win64-fixassert branch February 26, 2025 13:03
delta1 added a commit that referenced this pull request Feb 28, 2025
@delta1
Merge df4e99d into merged_master (Elements PR #1423)
6b82cfa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delta1 delta1 delta1 approved these changes

@apoelstra apoelstra Awaiting requested review from apoelstra

Assignees

@psgreco psgreco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psgreco @delta1