fuzz: minor updates to the Simplicity fuzz tests #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delta1
approved these changes
Feb 14, 2025
roconnor-blockstream
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
LGTM. This line now seems to be covered by the fuzzer.
elements/src/script/interpreter.cpp
Line 3149 in 0397d22
delta1
added a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bit of dead code laying around, and also we weren't hitting the
ERR_CMRerror return of the Simplicity interpreter. The former is easy and the latter I was able to hit with a little bit of trickery, without duplicating any work or requiring any new test seeds.