Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant words #1407

Closed
wants to merge 1 commit into from

Conversation

tianzedavid
Copy link

remove redundant words

@apoelstra
Copy link
Member

Thanks! But any changes in src/secp256k1 need to be filed upstream at https://github.com/BlockstreamResearch/secp256k1-zkp/ (or maybe even upstreamer at https://github.com/bitcoin-core/secp256k1/ , though any issues there have probably been long since fixed). And any changes in src/simplicity need to be filed upstream at https://github.com/BlockstreamResearch/simplicity (we are up-to-date there, so any issues you see here will also be present there).

chore: remove redundant words

Signed-off-by: tianzedavid <[email protected]>
@tianzedavid
Copy link
Author

Thanks! But any changes in src/secp256k1 need to be filed upstream at https://github.com/BlockstreamResearch/secp256k1-zkp/ (or maybe even upstreamer at https://github.com/bitcoin-core/secp256k1/ , though any issues there have probably been long since fixed). And any changes in src/simplicity need to be filed upstream at https://github.com/BlockstreamResearch/simplicity (we are up-to-date there, so any issues you see here will also be present there).

Thanks for your reply.

Reverted. Please review again.

@apoelstra
Copy link
Member

utACK e982627 -- though I am still unsure if we will accept this, since these files were unchanged since our fork of Bitcoin Core and we may want to let these fixes come in during our rebase process.

@tianzedavid
Copy link
Author

utACK e982627 -- though I am still unsure if we will accept this, since these files were unchanged since our fork of Bitcoin Core and we may want to let these fixes come in during our rebase process.

It's ok, thank you for your reply

@@ -116,7 +116,7 @@ added to and removed (spent) from the cache when we connect a new block.
(`chainstate.CoinsTip()`). For example, the RPCs `generateblock` and
`getblocktemplate` call `TestBlockValidity()`, which applies the UTXO set
changes to a temporary cache. Similarly, mempool consistency checks, which are
frequent on regtest, also apply the the UTXO set changes to a temporary cache.
frequent on regtest, also apply the UTXO set changes to a temporary cache.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@delta1
Copy link
Member

delta1 commented Feb 13, 2025

fixed from upstream

@delta1 delta1 closed this Feb 13, 2025
fanquake added a commit to bitcoin/bitcoin that referenced this pull request Feb 13, 2025
033acdf chore: remove redundant word (tianzedavid)

Pull request description:

  Remove redundant word
  For ElementsProject/elements#1407

ACKs for top commit:
  maflcko:
    lgtm ACK 033acdf
  delta1:
    ACK 033acdf

Tree-SHA512: ec9c9951c0153fa598d7733cfba287217c4a3389090a6d106d9144ac9cb1c13cf854f660fe187dad992b6ae1b252c01f1764af5bba5bdf8703b978d04cdb190f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants