-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 23.2.7 rc2 #1405
Merged
delta1
merged 25 commits into
ElementsProject:elements-23.2.x
from
psgreco:elem-23.2.7rc2
Feb 12, 2025
Merged
Prepare 23.2.7 rc2 #1405
delta1
merged 25 commits into
ElementsProject:elements-23.2.x
from
psgreco:elem-23.2.7rc2
Feb 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have an unsigned constant which we're bit-inverting, or'ing into a signed constant, then assigning back to the signed constant. We should make it explicit wth is going on here.
This originates in 8723deb which has no PR associated with it. We've really gotta stop putting thousands of unreviewed commits into this project and rebasing the history away..
Cherry-pick of bitcoin/bitcoin#24625 (1/2)
Cherry-pick of fa84a49 bitcoin/bitcoin#24625 (2/2)
Avoids a signed/unsigned integer conversion.
decodepsbt: add asset/assetcommitment to input.witness_utxo
…fixes various bugfixes for new fuzz test vectors
* feeDelta tracked the delta (to be applied on top of the actual fee) * m_modified_fee tracks the actual fee with the delta included * Instead of passing in the new total delta to the Updater, pass in by how much the total delta should be modified. This is needed for the next commit, but makes sense on its own because the same is done by UpdateDescendantState and UpdateAncestorState. Cherry-pick of fa52cf8 bitcoin/bitcoin#23418 (1/2)
Cherry-pick of fa52cf8 bitcoin/bitcoin#23418 (2/2)
Could be tested as follows: ``` % brew install [email protected] % ./autogen.sh % ./configure --with-boost='/opt/homebrew/opt/[email protected]' ``` (cherry picked from commit 1d4157a)
(cherry picked from commit 532c64a)
(cherry picked from commit fadeb6b)
Additional include fixes are required to make the 23.x branch compile using GCC 13. (cherry picked from commit af86266)
Fix build in master with newer environments
…fixes-2 more fuzzer fixes (continuation of ElementsProject#1399)
This reverts commit b90ef38.
…02--misc-fuzz-fixes" This reverts commit acbb8b5.
utACK 42554a4 |
71a1be1
into
ElementsProject:elements-23.2.x
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included:
1 . Version bump
2. Reapply the erroneously reverted #1391
3. Updates from master (without simpplicity) up to d020546