Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 23.2.7 rc2 #1405

Merged
merged 25 commits into from
Feb 12, 2025
Merged

Conversation

psgreco
Copy link
Contributor

@psgreco psgreco commented Feb 11, 2025

Changes included:
1 . Version bump
2. Reapply the erroneously reverted #1391
3. Updates from master (without simpplicity) up to d020546

delta1 and others added 25 commits November 1, 2024 09:22
We have an unsigned constant which we're bit-inverting, or'ing into a
signed constant, then assigning back to the signed constant. We should
make it explicit wth is going on here.
This originates in 8723deb which has no
PR associated with it. We've really gotta stop putting thousands of
unreviewed commits into this project and rebasing the history away..
Avoids a signed/unsigned integer conversion.
decodepsbt: add asset/assetcommitment to input.witness_utxo
…fixes

various bugfixes for new fuzz test vectors
* feeDelta tracked the delta (to be applied on top of the actual fee)
* m_modified_fee tracks the actual fee with the delta included
* Instead of passing in the new total delta to the Updater, pass in by
  how much the total delta should be modified.

This is needed for the next commit, but makes sense on its own because
the same is done by UpdateDescendantState and UpdateAncestorState.

Cherry-pick of fa52cf8
bitcoin/bitcoin#23418 (1/2)
Could be tested as follows:
```
% brew install [email protected]
% ./autogen.sh
% ./configure --with-boost='/opt/homebrew/opt/[email protected]'
```

(cherry picked from commit 1d4157a)
Additional include fixes are required to make the 23.x branch compile
using GCC 13.

(cherry picked from commit af86266)
Fix build in master with newer environments
@psgreco psgreco marked this pull request as ready for review February 11, 2025 20:22
@delta1
Copy link
Member

delta1 commented Feb 12, 2025

utACK 42554a4

@delta1 delta1 merged commit 71a1be1 into ElementsProject:elements-23.2.x Feb 12, 2025
12 of 13 checks passed
@psgreco psgreco deleted the elem-23.2.7rc2 branch February 12, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants