bump elements and related dep

[RCasatta]

apoelstra, there are some places where I need guidance

Also, I still need to check CI, just tested local cargo check and cargo test are working for now

[RCasatta]

this line fails because variant or associated item cannot be called on Descriptor<Pk> due to unsatisfied trait bounds and I don't get what I can do about that

[apoelstra]

In the impl_from_tree macro we have a ton of bounds on Pk. Upstream these have all been wrapped up into the FromStrKey trait which you need to update the macro to use instead.

If you change this line to call bitcoin_miniscript::expression::FromTree::from_tree you will get a much better error message from the compiler.

[RCasatta]

Done in e6724fc

[RCasatta]

just realized we need a simplicity dep bump before this https://github.com/BlockstreamResearch/rust-simplicity

I left separated commit for now for easier review, will squash in 1 commit at the end

[apoelstra]

Sorry for the long delay. There is a clippy issue I'd like you to fix

error: useless conversion to the same type: `miniscript::RelLockTime`
   --> src/descriptor/pegin/legacy_pegin.rs:148:17
    |
148 |                 bitcoin_miniscript::RelLockTime::try_from(timelock).expect("TODO"),
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider removing `bitcoin_miniscript::RelLockTime::try_from()`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-D clippy::useless-conversion` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

Not sure why CI is not complaining about this.

[RCasatta]

clippy fixed, note that now that I checked I've hit also the following one, not sure if you didn't mention this because we want to allow it or what

warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`
    --> src/descriptor/mod.rs:1019:36
     |
1019 |           if !self.for_any_key(|key| {
     |  ____________________________________^
1020 | |             // All multipath keys must have the same number of indexes at the "multi-index"
1021 | |             // step. So we can return early if we already populated the vector.
1022 | |             if !descriptors.is_empty() {
...    |
1034 | |             }
1035 | |         }) {
     | |_________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_conditions
     = note: `#[warn(clippy::blocks_in_conditions)]` on by default

[apoelstra]

I don't see that one, but I do see several related to doccomments. I'm not sure what's up. But sounds like we should just do a followup with clippy fixes rather than iterating on this one. Clippy wasn't happy on master either.

[apoelstra]

ACK 6ed3bbb

[apoelstra]

ACK 6ed3bbb