Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation extents dots #594

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Translation extents dots #594

merged 3 commits into from
Jan 7, 2025

Conversation

Louis-Happel
Copy link
Contributor

@Louis-Happel Louis-Happel commented Jan 7, 2025

Added "." as valid character for translation line extents for the side tags ("b.e.","t.e."...).

Summary by Sourcery

Bug Fixes:

  • Fixed a bug where translation extent tags could not contain dots.

Copy link
Contributor

sourcery-ai bot commented Jan 7, 2025

Reviewer's Guide by Sourcery

This pull request adds support for dots in side tags (e.g., "b.e.", "t.e.") used in translation line extents. The change involves updating the regular expression for extent labels in the oracc_atf_translation_line.lark file to include dots.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added support for dots in extent labels
  • Updated the regular expression for extent labels to include dots
  • Ensured that existing functionality remains unaffected
ebl/atf_importer/domain/lark-oracc/oracc_atf_translation_line.lark

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Louis-Happel - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide test cases demonstrating the valid and invalid uses of escaped dots in translation line extents
  • Could you expand the PR description to explain the motivation for this change and provide some example use cases?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codeclimate bot commented Jan 7, 2025

Code Climate has analyzed commit 28c5756 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (75% is the threshold).

This pull request will bring the total coverage in the repository to 91.4% (0.0% change).

View more on Code Climate.

@ejimsan ejimsan merged commit 26503ae into master Jan 7, 2025
12 checks passed
@ejimsan ejimsan deleted the translationExtentsDots branch January 7, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants