-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation extents dots #594
Conversation
Reviewer's Guide by SourceryThis pull request adds support for dots in side tags (e.g., "b.e.", "t.e.") used in translation line extents. The change involves updating the regular expression for extent labels in the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Louis-Happel - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide test cases demonstrating the valid and invalid uses of escaped dots in translation line extents
- Could you expand the PR description to explain the motivation for this change and provide some example use cases?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Code Climate has analyzed commit 28c5756 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (75% is the threshold). This pull request will bring the total coverage in the repository to 91.4% (0.0% change). View more on Code Climate. |
Added "." as valid character for translation line extents for the side tags ("b.e.","t.e."...).
Summary by Sourcery
Bug Fixes: