Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace --no-dev by --only main #592

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Replace --no-dev by --only main #592

merged 1 commit into from
Jan 5, 2025

Conversation

ejimsan
Copy link
Member

@ejimsan ejimsan commented Jan 5, 2025

Summary by Sourcery

Build:

  • Install only the main dependencies instead of all dependencies except dev dependencies.

Copy link
Contributor

sourcery-ai bot commented Jan 5, 2025

Reviewer's Guide by Sourcery

This pull request replaces the --no-dev flag with --only main when installing poetry dependencies.

Sequence diagram for poetry dependency installation process

sequenceDiagram
    participant D as Dockerfile
    participant P as Poetry
    participant M as Main Dependencies
    D->>P: Install dependencies
    Note over P: Changed flag from --no-dev to --only main
    P->>M: Install only main dependencies
    Note over M: Same result as before,
    Note over M: but using newer Poetry syntax
Loading

File-Level Changes

Change Details Files
Replaced the poetry install flag to include only main dependencies.
  • Changed --no-dev to --only main in the poetry install command
Dockerfile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.

Copy link

codeclimate bot commented Jan 5, 2025

Code Climate has analyzed commit 6b466f3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (75% is the threshold).

This pull request will bring the total coverage in the repository to 91.5% (0.0% change).

View more on Code Climate.

@ejimsan ejimsan merged commit a69f50f into master Jan 5, 2025
12 checks passed
@ejimsan ejimsan deleted the update-docker branch January 5, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant