add sector

[zsomborfoldi]

Summary by Sourcery

New Features:

• Add a 'sector' field to the Findspot schema, domain model, and test factory.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR adds a new 'sector' field to the Findspot model in the archaeology module. The implementation includes adding the field to the domain model, schema, and test factory.

Updated class diagram for the Findspot model

classDiagram
    class Findspot {
        int id_
        Optional~ExcavationSite~ site
        str sector
        str area
        str building
        Optional~BuildingType~ building_type
    }
    note for Findspot "Added 'sector' field of type str"

Loading

File-Level Changes

Change	Details	Files
Added a new 'sector' string field to the Findspot model	Added 'sector' as an optional string field to the FindspotSchema Added 'sector' property to the Findspot domain class with empty string default Added 'sector' field generation in the FindspotFactory using Faker word generator	ebl/fragmentarium/application/archaeology_schemas.py ebl/fragmentarium/domain/findspot.py ebl/tests/factories/archaeology.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @zsomborfoldi - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codeclimate]

Code Climate has analyzed commit a77bede and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (75% is the threshold).

This pull request will bring the total coverage in the repository to 91.4% (0.0% change).

View more on Code Climate.