Make archaeology date start optional

[ejimsan]

Summary by Sourcery

Enhancements:

• Make the 'start' field in DateRangeSchema optional by allowing None values.

[sourcery-ai]

Reviewer's Guide by Sourcery

The PR modifies the date range schema to make the start date optional by changing the start field from required to nullable in the DateRangeSchema class.

Updated class diagram for DateRangeSchema

classDiagram
    class DateRangeSchema {
        - PartialDateSchema start
        + PartialDateSchema start
        + PartialDateSchema end
        + String notes
    }
    class PartialDateSchema
    DateRangeSchema --> PartialDateSchema
    note for DateRangeSchema "The 'start' field is now optional (nullable)."

Loading

File-Level Changes

Change	Details	Files
Modified date range schema to make start date optional	Changed start field from required=True to allow_none=True in DateRangeSchema Aligned start field configuration with existing end field configuration	ebl/fragmentarium/application/date_schemas.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ejimsan - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please provide documentation explaining the use case for null start dates and how they should be interpreted
• Consider if a more explicit approach (like a sentinel value or separate type) would be clearer than allowing null start dates

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codeclimate]

Code Climate has analyzed commit e4ef8a2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (75% is the threshold).

This pull request will bring the total coverage in the repository to 91.4% (0.0% change).

View more on Code Climate.