Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no longer visible (°) to ATF Grammar #575

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

ejimsan
Copy link
Member

@ejimsan ejimsan commented Sep 25, 2024

Summary by Sourcery

Add the 'no longer visible' status to the ATF grammar and update related documentation and tests to support this new status.

New Features:

  • Introduce a new 'no longer visible' status represented by the symbol '°' in the ATF grammar.

Documentation:

  • Update the ATF grammar documentation to include the 'no longer visible' status.

Tests:

  • Add test cases for the new 'no longer visible' status in the transliteration parsing tests.

Copy link
Contributor

sourcery-ai bot commented Sep 25, 2024

Reviewer's Guide by Sourcery

This pull request adds support for the 'no longer visible' symbol (°) to the ATF Grammar. It updates the grammar definition, enum values, and related test cases to include this new symbol.

File-Level Changes

Change Details Files
Add 'no longer visible' symbol (°) to ATF Grammar
  • Update dollar-status definition to include '°'
  • Add 'no-longer-visible' to the flag definition
  • Define 'no-longer-visible' as '°'
  • Add NO_LONGER_VISIBLE enum value to DollarStatus
docs/ebl-atf.md
ebl/transliteration/domain/atf.py
Update test cases to include 'no longer visible' symbol
  • Add test case for '°' symbol in parse_ruling_dollar_line
  • Add test case for '°' symbol in parse_state_dollar_line_exhaustive
ebl/tests/transliteration/test_parse_ruling_dollar_line.py
ebl/tests/transliteration/test_parse_state_dollar_line_exhaustive.py

Sequence Diagram

No sequence diagram generated.


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ejimsan - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

docs/ebl-atf.md Show resolved Hide resolved
Copy link

codeclimate bot commented Sep 25, 2024

Code Climate has analyzed commit 5dc4446 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (75% is the threshold).

This pull request will bring the total coverage in the repository to 91.4% (0.0% change).

View more on Code Climate.

@ejimsan ejimsan merged commit ce78800 into master Sep 25, 2024
12 checks passed
@ejimsan ejimsan deleted the no-longer-visible branch September 25, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant