Skip to content

Commit

Permalink
Add Alalah HPM number to external numbers
Browse files Browse the repository at this point in the history
ejimsan committed Feb 14, 2024
1 parent 0458327 commit 6c34e11
Showing 3 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions ebl/fragmentarium/application/fragment_schema.py
Original file line number Diff line number Diff line change
@@ -141,6 +141,7 @@ class ExternalNumbersSchema(Schema):
metropolitan_number = fields.String(load_default="", data_key="metropolitanNumber")
yale_peabody_number = fields.String(load_default="", data_key="yalePeabodyNumber")
louvre_number = fields.String(load_default="", data_key="louvreNumber")
alalah_hpm_number = fields.String(load_default="", data_key="alalahHpmNumber")
philadelphia_number = fields.String(load_default="", data_key="philadelphiaNumber")
australianinstituteofarchaeology_number = fields.String(
load_default="", data_key="australianinstituteofarchaeologyNumber"
5 changes: 5 additions & 0 deletions ebl/fragmentarium/domain/fragment.py
Original file line number Diff line number Diff line change
@@ -104,6 +104,7 @@ class ExternalNumbers:
hilprecht_heidelberg_number: str = ""
metropolitan_number: str = ""
louvre_number: str = ""
alalah_hpm_number: str = ""
australianinstituteofarchaeology_number: str = ""
philadelphia_number: str = ""
achemenet_number: str = ""
@@ -269,6 +270,10 @@ def metropolitan_number(self) -> str:
def louvre_number(self) -> str:
return self._get_external_number("louvre_number")

@property
def alalah_hpm_number(self) -> str:
return self._get_external_number("alalah_hpm_number")

@property
def australianinstituteofarchaeology_number(self) -> str:
return self._get_external_number("australianinstituteofarchaeology_number")
1 change: 1 addition & 0 deletions ebl/tests/factories/fragment.py
Original file line number Diff line number Diff line change
@@ -171,6 +171,7 @@ class Meta:
)
metropolitan_number = factory.Sequence(lambda n: f"metropolitan-number-{n}")
louvre_number = factory.Sequence(lambda n: f"louvre-number-{n}")
alalah_hpm_number = factory.Sequence(lambda n: f"alalah_hpm_number-{n}")
australianinstituteofarchaeology_number = factory.Sequence(
lambda n: f"australianinstituteofarchaeology-number-{n}"
)

0 comments on commit 6c34e11

Please sign in to comment.