Add philadelphiaNumber (#478)

ElectronicBabylonianLiterature · Nov 2, 2023 · 2edefbf · 2edefbf
1 parent 42e1866
commit 2edefbf
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/ebl/fragmentarium/application/fragment_schema.py b/ebl/fragmentarium/application/fragment_schema.py
@@ -140,6 +140,7 @@ class ExternalNumbersSchema(Schema):
     metropolitan_number = fields.String(load_default="", data_key="metropolitanNumber")
     yale_peabody_number = fields.String(load_default="", data_key="yalePeabodyNumber")
     louvre_number = fields.String(load_default="", data_key="louvreNumber")
+    philadelphia_number = fields.String(load_default="", data_key="philadelphiaNumber")
     oracc_numbers = fields.List(
         fields.String(), load_default=tuple(), data_key="oraccNumbers"
     )

diff --git a/ebl/fragmentarium/domain/fragment.py b/ebl/fragmentarium/domain/fragment.py
@@ -103,6 +103,7 @@ class ExternalNumbers:
     hilprecht_heidelberg_number: str = ""
     metropolitan_number: str = ""
     louvre_number: str = ""
+    philadelphia_number: str = ""
     yale_peabody_number: str = ""
     oracc_numbers: Sequence[str] = tuple()
 
@@ -264,3 +265,7 @@ def metropolitan_number(self) -> str:
     @property
     def louvre_number(self) -> str:
         return self._get_external_number("louvre_number")
+
+    @property
+    def philadelphia_number(self) -> str:
+        return self._get_external_number("philadelphia_number")
diff --git a/ebl/tests/factories/fragment.py b/ebl/tests/factories/fragment.py
@@ -166,6 +166,7 @@ class Meta:
     )
     metropolitan_number = factory.Sequence(lambda n: f"metropolitan-number-{n}")
     louvre_number = factory.Sequence(lambda n: f"louvre-number-{n}")
+    philadelphia_number = factory.Sequence(lambda n: f"philadelphia-number-{n}")
     yale_peabody_number = factory.Sequence(lambda n: f"yale-peabody-number-{n}")
     oracc_numbers = factory.List(
         [factory.Sequence(lambda n: f"oracc-number-{n}")], TupleFactory