Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused TransactionEncoder functions #1660

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

HonzaR
Copy link
Contributor

@HonzaR HonzaR commented Dec 13, 2024

  • These changes remove unused SDK internal TransactionEncoder functions that were used by previously removed deprecated functions Synchronizer.sendToAddress and Synchronizer.shieldFunds in [#1632] Refactor Account.DEFAULT #1645

Note
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

  • Self-review your own code in GitHub's web interface1
  • Add automated tests as appropriate
  • Update the manual tests2 as appropriate
  • Check the code coverage3 report for the automated tests
  • Update documentation as appropriate (e.g README.md, Architecture.md, etc.)
  • Run the demo app and try the changes
  • Pull in the latest changes from the main branch and squash your commits before assigning a reviewer4

Reviewer

  • Check the code with the Code Review Guidelines checklist
  • Perform an ad hoc review5
  • Review the automated tests
  • Review the manual tests
  • Review the documentation, README.md, Architecture.md, etc. as appropriate
  • Run the demo app and try the changes6

Footnotes

  1. Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.

  2. While we aim for automated testing of the SDK, some aspects require manual testing. If you had to manually test
    something during development of this pull request, write those steps down.

  3. While we are not looking for perfect coverage, the tool can point out potential cases that have been missed. Code coverage can be generated with: ./gradlew check for Kotlin modules and ./gradlew connectedCheck -PIS_ANDROID_INSTRUMENTATION_TEST_COVERAGE_ENABLED=true for Android modules.

  4. Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

  5. In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.

  6. While the CI server runs the demo app to look for build failures or crashes, humans running the demo app are
    more likely to notice unexpected log messages, UI inconsistencies, or bad output data. Perform this step last, after verifying the code changes are safe to run locally.

@HonzaR HonzaR merged commit abb2c9c into feature-2.2.7 Dec 13, 2024
10 of 12 checks passed
@HonzaR HonzaR deleted the remove-unused-trx-fce branch December 13, 2024 10:39
HonzaR added a commit that referenced this pull request Dec 13, 2024
HonzaR added a commit that referenced this pull request Dec 13, 2024
* Migrate to latest revision of Zcash crates

* Integrate PCZT APIs into the Android SDK

* Fix `Backend.createPcztFromProposal` parameter

* Add Synchronizer side of PCZT logic

* Add `getAccountForUfvk`  method to Rust backend & fix key derivation null issue. (#1656)

* Add `getAccountForUfvk` method to the FFI.

* Only decode key derivation metadata when creating a count with `Spending` purpose.

Also, ensure that a spending account can still be created without providing
key derivation metadata.

* Update to `librustzcash` revision `205d4c930319b7b6d24aeb4efde69e9b4d1b6f7b`

* Add the new `getAccountForUfvk` to `TypesafeBackend`

* Update `FakeRustBackend`

---------

Co-authored-by: Honza <[email protected]>

* Remove unused `TransactionEncoder` functions (#1660)

* Resolve [#1640] review comments

* `Account` documentation fix

* Make `AccountPurpose.Spending` args not null

As they now live under `AccountPurpose.Spending` where we need them not null
+ `AccountImportSetup` doc fix

* Replace `bytes` with `usk` in `AccountUsk`

* Change test name

* Testnet Synchronizer test fix

* Detekt warning

* Changelog update

---------

Co-authored-by: Jack Grigg <[email protected]>
Co-authored-by: Honza <[email protected]>
Co-authored-by: Honza Rychnovský <[email protected]>
HonzaR added a commit that referenced this pull request Dec 17, 2024
* [#1632] Refactor `Account.DEFAULT` (#1645)

* [#1632] Remove `Account.DEFAULT`

* Update Account related APIs

* Refactor balances APIs

* Adopt `getAccounts` in fragment-based Demo app

We have deprecated the old Fragment-based Demo app. See #973. So, the purpose of these changes is purely the buildability of the new Compose-based Demo app.

* Add init to `JniUnifiedSpendingKey.kt`

* Update deprecated Fragment-based Demo app

This part of the Demo app will be removed as part of #973

* Remove deprecated functions from Synchronizer

* Update WalletSnapshot and WalletVM APIs in Demo

+ necessary fixtures changes

* Update newer Compose-based Demo app

* Hide `Synchronizer.createAccount` form public API

As it was, as making it public could bring more requirements on our multi-account support in version 1

* Add all accounts flow API

* Refactor AccountFixture

- We deduplicated the fixture across the related modules and their tests
- Documentation added

* Fix `fetchUtxos` error (code 14)

- Closes #1648
- This also impacts SDK’s ability to recover from loss of internet connection
- Changelog updated

* Switch from ZIP 32 account indices to UUID account identifiers (#1640)

* Switch from ZIP 32 account indices to UUID account identifiers

* Rename TransactionRecipient.Account

To emphasize the distinction between Account and TransactionRecipient.Account

* Fix `Backend.createAccount` API parameters

* Add `importAccountUfvk` to the Rust backend.

* Propagate accountName and keySource across SDK

* Propagate new importAccount across SDK

* Wrap createAccount setup information

* Wrap importAccount setup information

* Add `Zip32AccountIndex` wrapper

* Update key source parameter

* Remove account from `UnifiedSpendingKey`

* Fix `importAccountByUfvk` API

* Refactor Account.accountUuid to wrapper class

So we can easily keep it typesafe and compare it to each other

* Add `JniAccountUsk`

* Add `seedFingerprint` and `zip32AccountIndex`

To public API `importAccountUfvk`

* Transactions by account UUID

* Refactor default account creation

* Migrate to Rust crate revision with bugfixes to account UUID migration

* Refactor inputs of `importAccountUfvk`

* Use `FirsClassByteArray` for `seed` parameter

---------

Co-authored-by: Honza <[email protected]>
Co-authored-by: Kris Nuttycombe <[email protected]>
Co-authored-by: Honza Rychnovský <[email protected]>
Co-authored-by: Daira-Emma Hopwood <[email protected]>

* Remove unused `TransactionEncoder` functions (#1660)

* Resolve [#1640] review comments

* `Account` documentation fix

* Make `AccountPurpose.Spending` args not null

As they now live under `AccountPurpose.Spending` where we need them not null
+ `AccountImportSetup` doc fix

* Replace `bytes` with `usk` in `AccountUsk`

* Change test name

* Feature/proposal to pczt (#1647)

* Migrate to latest revision of Zcash crates

* Integrate PCZT APIs into the Android SDK

* Fix `Backend.createPcztFromProposal` parameter

* Add Synchronizer side of PCZT logic

* Add `getAccountForUfvk`  method to Rust backend & fix key derivation null issue. (#1656)

* Add `getAccountForUfvk` method to the FFI.

* Only decode key derivation metadata when creating a count with `Spending` purpose.

Also, ensure that a spending account can still be created without providing
key derivation metadata.

* Update to `librustzcash` revision `205d4c930319b7b6d24aeb4efde69e9b4d1b6f7b`

* Add the new `getAccountForUfvk` to `TypesafeBackend`

* Update `FakeRustBackend`

---------

Co-authored-by: Honza <[email protected]>

* Remove unused `TransactionEncoder` functions (#1660)

* Resolve [#1640] review comments

* `Account` documentation fix

* Make `AccountPurpose.Spending` args not null

As they now live under `AccountPurpose.Spending` where we need them not null
+ `AccountImportSetup` doc fix

* Replace `bytes` with `usk` in `AccountUsk`

* Change test name

* Testnet Synchronizer test fix

* Detekt warning

* Changelog update

---------

Co-authored-by: Jack Grigg <[email protected]>
Co-authored-by: Honza <[email protected]>
Co-authored-by: Honza Rychnovský <[email protected]>

* Peformance optimizations

* Revert "Peformance optimizations"

This reverts commit 68de6ae.

* PCZT support follow-ups (#1663)

* Rename exception

* Add sapling param fetching to new KS-related fun

* Add dedicated clone PZCT function

* Add `Synchronizer.Status.INITIALIZING`

For wallets to know that accounts and other APIs are not ready yet

* [#1665] Checkpoints update

Closes #1665

* Bump lib version to 2.2.7

* Migrate to the published Zcash crate releases including PCZT v1 (#1664)

Co-authored-by: Honza <[email protected]>

---------

Co-authored-by: Jack Grigg <[email protected]>
Co-authored-by: Kris Nuttycombe <[email protected]>
Co-authored-by: Daira-Emma Hopwood <[email protected]>
Co-authored-by: Kris Nuttycombe <[email protected]>
Co-authored-by: Milan Cerovsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants