Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bw): cannot select all numeric values for some fields. #5420

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Aug 12, 2024

Fixes #5419

Don't use 'isValueAvailable' function when editing a numeric value.

@philmoz philmoz added this to the 2.11 milestone Aug 12, 2024
@philmoz philmoz added UX-UI Related to user experience (UX) or user interface (UI) behaviour B&W Related generally to black and white LCD radios bug/regression ↩️ A new version of EdgeTX broke something labels Aug 12, 2024
@inventor7777
Copy link

Thanks for this! I can now select all expo values! 🎉

@philmoz philmoz marked this pull request as draft August 12, 2024 23:55
@philmoz philmoz marked this pull request as ready for review August 13, 2024 01:12
@philmoz
Copy link
Collaborator Author

philmoz commented Aug 13, 2024

Hopefully this will work now for all cases. PR #5220 has some caused some unexpected side effects.

@pfeerick
Copy link
Member

pfeerick commented Aug 13, 2024

Deja vu about eggs and omelettes... 🤣
image

@pfeerick pfeerick self-requested a review August 13, 2024 02:25
@pfeerick
Copy link
Member

pfeerick commented Aug 13, 2024

LGTM (MT12) :)

@pfeerick pfeerick merged commit 0594dab into main Aug 13, 2024
47 checks passed
@pfeerick pfeerick deleted the philmoz/fix-5419 branch August 13, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios bug/regression ↩️ A new version of EdgeTX broke something UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expo values from 3 to 75 missing
3 participants