Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "Trims" option to Reset special function #5278

Merged
merged 7 commits into from
Jul 28, 2024
Merged

Conversation

3djc
Copy link
Collaborator

@3djc 3djc commented Jul 10, 2024

Fixes #5274

Summary of changes:
adds "trims" choice to reset function. Activate reset all trims to 0 in current flight mode.

@3djc
Copy link
Collaborator Author

3djc commented Jul 10, 2024

@elecpower could you have a look at the companion side. Tested it ok, but I might have overlocked something

@elecpower
Copy link
Collaborator

@elecpower could you have a look at the companion side. Tested it ok, but I might have overlocked something

I've only had time for a quick desk check and I pretty sure there are some more +2 -> +3 changes required as sensors follow your new Trim

@3djc
Copy link
Collaborator Author

3djc commented Jul 11, 2024

@elecpower could you have a look at the companion side. Tested it ok, but I might have overlocked something

I've only had time for a quick desk check and I pretty sure there are some more +2 -> +3 changes required as sensors follow your new Trim

Was able to find 2 more, also used a constant

@elecpower
Copy link
Collaborator

@3djc I took some liberties, hope you don't mind. Also uncovered a couple of source inversion introduced bugs which I have fixed here as well as a separate PR in case @pfeerick merges in different order.
Tested in Companion and checked tx16s simulator mirrored the settings. So its a tick from me.

@elecpower elecpower self-requested a review July 12, 2024 01:48
elecpower
elecpower previously approved these changes Jul 12, 2024
@raphaelcoeffic raphaelcoeffic added the enhancement ✨ New feature or request label Jul 12, 2024
@3djc
Copy link
Collaborator Author

3djc commented Jul 12, 2024

Thanks a lot Neil :)

@elecpower
Copy link
Collaborator

and then an after-thought about my millstone binary import

@pfeerick pfeerick changed the title Add Reset trims special function feat: add "Trims" option to Reset special function Jul 13, 2024
@pfeerick pfeerick added this to the 2.11 milestone Jul 13, 2024
@pfeerick pfeerick self-requested a review July 18, 2024 03:48
@pfeerick pfeerick force-pushed the 3djc/SF-Reset-trims branch from d24cad6 to c54728d Compare July 26, 2024 11:11
@pfeerick
Copy link
Member

LGTM on TX12MK2 :)

@pfeerick pfeerick merged commit 2638c6d into main Jul 28, 2024
48 of 49 checks passed
@pfeerick pfeerick deleted the 3djc/SF-Reset-trims branch July 28, 2024 01:45
@TGS78
Copy link

TGS78 commented Aug 24, 2024

Is it possible to reset individual trims instead of all?

@pfeerick
Copy link
Member

Not a present I think. I was about to say this level of detail may be better via Lua script, but it doesn't seem possible there. So maybe it would be an idea to be able to reset the individual trims also as a further extension of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option for not saving trims
5 participants