Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(color): allow changing the size of topbar widgets #5235

Merged
merged 14 commits into from
Jul 27, 2024
Merged

feat(color): allow changing the size of topbar widgets #5235

merged 14 commits into from
Jul 27, 2024

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Jul 1, 2024 •
edited by pfeerick
Loading

Allows the user to specify how many slots each widget can occupy.
Each widget size can be set to a multiple of the default size - default is x1 to match current layout.

Default layout:
screenshot_tx16s_24-07-01_10-27-40

Adjust layout:
screenshot_tx16s_24-07-01_10-27-57

Adjusted main view:
screenshot_tx16s_24-07-01_13-53-04

The setup UI is basic so any suggestions for making it nicer appreciated.

TODO:

  • Translation strings.

@philmoz philmoz force-pushed the philmoz/topbar-widget-width branch from a5b2221 to bb95543 Compare July 1, 2024 10:20
@philmoz philmoz added this to the 2.11 milestone Jul 1, 2024
@philmoz philmoz added enhancement ✨ New feature or request color Related generally to color LCD radios labels Jul 1, 2024
@philmoz philmoz force-pushed the philmoz/topbar-widget-width branch 2 times, most recently from f8a4f24 to 9b8b5a4 Compare July 4, 2024 06:56
@pfeerick
Copy link
Member

pfeerick commented Jul 4, 2024

The setup UI is basic so any suggestions for making it nicer appreciated.

Basic is good... nice and simple ;) Not sure it could be done any better.. sure... could probably be fancier, but probably more complicated to use too.

@ulfhedlund
Copy link
Contributor

SE translation:
#define TR_WIDGET_SIZE "Widgetstorlek"

@philmoz philmoz force-pushed the philmoz/topbar-widget-width branch 2 times, most recently from 7fdd291 to ab712c7 Compare July 6, 2024 05:45
@pfeerick pfeerick self-requested a review July 9, 2024 01:03
@philmoz philmoz force-pushed the philmoz/topbar-widget-width branch 2 times, most recently from 04ea00f to b0fbfb6 Compare July 16, 2024 23:00
@pfeerick
Copy link
Member

pfeerick commented Jul 18, 2024 •
edited by philmoz
Loading

Can we get some translations for this please 😃 Will be merged in seven days or when translations complete, whichever comes first.

#define TR_WIDGET_SIZE "Widget size"

@robustini
Copy link
Contributor

IT
#define TR_WIDGET_SIZE "Dimensione widget"

@Eldenroot
Copy link
Contributor

CZ:

Velikost widgetu

@Pat6874
Copy link
Contributor

Pat6874 commented Jul 18, 2024 via email

@ParkerEde
Copy link
Contributor

DE:
#define TR_WIDGET_SIZE "Widget Größe"

@zyren
Copy link
Contributor

zyren commented Jul 18, 2024

CN

#define TR_WIDGET_SIZE "小部件尺寸"

TW

#define TR_WIDGET_SIZE "小部件尺寸"

@elektro-NIK
Copy link
Contributor

UA
#define TR_WIDGET_SIZE "Розмір віджета"

@ToshihiroMakuuchi
Copy link
Contributor

JP
#define TR_WIDGET_SIZE "ウィジェットサイズ"

@philmoz philmoz force-pushed the philmoz/topbar-widget-width branch from 77b6d8c to 8d189f6 Compare July 19, 2024 22:42
@ajjjjjjjj
Copy link
Contributor

PL

#define TR_WIDGET_SIZE "Rozmiar widżetu"

@zandorsp
Copy link
Contributor

PT
#define TR_WIDGET_SIZE "Tamanho do widget"

@HThuren
Copy link
Contributor

HThuren commented Jul 24, 2024

DA translation:
#define TR_WIDGET_SIZE "Widget størrelse"

@philmoz philmoz force-pushed the philmoz/topbar-widget-width branch from b463cff to 4547c9b Compare July 26, 2024 00:00
@philmoz philmoz force-pushed the philmoz/topbar-widget-width branch from 4547c9b to 7507d90 Compare July 26, 2024 22:47
@pfeerick
Copy link
Member

For those who have asked about long model names in the topbar - this PR + https://github.com/offer-shmuely/edgetx-x10-widgets/blob/master/WIDGETS/ModelName/main.lua works perfectly ;)

image

@pfeerick pfeerick merged commit faf0027 into main Jul 27, 2024
50 checks passed
@pfeerick pfeerick deleted the philmoz/topbar-widget-width branch July 27, 2024 06:06
@pfeerick pfeerick added the rn: feature Feature to be highlighted in release notes label Jul 27, 2024
@philmoz philmoz mentioned this pull request Aug 2, 2024
Closed
@pfeerick pfeerick linked an issue Aug 2, 2024 that may be closed by this pull request
Make Top Bar Text Widgets able to span multiple widgets #970
Closed
@kobakirill
Copy link
Contributor

RU
#define TR_WIDGET_SIZE "Размер виджета"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeerick pfeerick Awaiting requested review from pfeerick

Assignees
No one assigned
Labels
color Related generally to color LCD radios enhancement ✨ New feature or request rn: feature Feature to be highlighted in release notes
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.

Make Top Bar Text Widgets able to span multiple widgets