-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(bw): tidy up Radio Setup menu #4939
Conversation
Very nice! |
I think we should move away from the indent been part of the translation string and use INDENT_WIDTH or similar in lcdDrawText() instead. It helps a lot when you have to resue that word |
ec5e3ea
to
1c5840e
Compare
I've cleaned up the usage of the INDENT macro in the code and replaced it with INDENT_WIDTH. |
Clearly, one step at a time! |
|
00f8a8a
to
a4e7bba
Compare
ec60cb9
to
9df9622
Compare
9df9622
to
2cedb5e
Compare
Fix inconsistencies in translation strings.
Cleanup code.
2cedb5e
to
7a4b0e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM also. Nice to see the GPS header for those options, as well as optimisation of some of the translation helper code. I noticed while reviewing that the "Default channel order" parameter was out of alignment (and has been for a while) by one character so fixed that also.
Summary of changes: