-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(cpn): Cloudbuild - phase 1 #4856
Conversation
Ready for playtime in the sandpit. |
Rodger Rodger... Will play with it on the weekend...
…On Fri, 12 Apr 2024, 8:47 am Neil Horne, ***@***.***> wrote:
Ready for playtime in the sandpit.
I have not tinkered with the Radio Profile options yet.
Refer description above for status.
—
Reply to this email directly, view it on GitHub
<#4856 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJ66KOF3BGCZWFYGH7UJBLY44HILAVCNFSM6AAAAABF3VAQQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJQGY3TONJUHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
9ccad33
to
e1ab7a8
Compare
e1ab7a8
to
efd907d
Compare
Quick run through until github rate limits said no... seems to be working just fine. Looking forward to phase 2 ;) Two minor niggles / food for future improvements :
|
This reverts commit 27f53ff.
aka complaints ;-)
Will have to work on this one as it comes down to the way the settings were implemented. There are two copies: one on disk and one in memory. Maybe I erred when implementing the Updates.
You don't want much. Cancel wasn't an option until now. But to be honest I also thought the cancel could go further in a later PR. The rework to cascade up the lower level cancel is not insignificant and I wanted to get this Beta version incorporated for some invaluable feedback from fellow devs. |
Could also be user error, as I hit the rate limit at the exact wrong time as I was trying to do a repeat test to confirm it wasn't PBKAC, but just wanted to flag it so it's at the back of your mind when working on this code... lol... more just QoL improvements that would nice to have some day (as would a "just go away already" button that was mentioned in another issue - to do with self inflicted "version not supported" warning for every single model file on the radio 😇 )... complaints get me stomping my (small) boots and waving a "thou shall not pass" sign 🤣 |
Your diligent testing and feedback is appreciated. These are on my TODO list. |
Fixes #4858
Summary of changes:
Status:
TODO:
Phase 2 (separate PR):