-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(color): add color options for radio info widget battery level indicator #4845
Conversation
Looks like we have miles of space there? So for DE: "Farbe Akku fast leer" If there is more space maybe insert a "bei" inbetween "Farbe" and "Akku" for extra clarity. Could we make the default "full" color depending on the theme secondary foreground (?) color (white in this case)? Green could look ugly with some themes or stick out too much visually when it doesn't need to. Battery full, all good, no need to visually alert the user? |
I have added translation strings for the widget names and settings. #define TR_DATE_TIME_WIDGET "Date & Time"
#define TR_RADIO_INFO_WIDGET "Radio Info"
#define TR_LOW_BATT_COLOR "Low battery"
#define TR_MID_BATT_COLOR "Mid battery"
#define TR_HIGH_BATT_COLOR "High battery" |
'fraid so... and sorry for just clobbering this with your other PR 🤪 translations seem to like to always collide |
541410c
to
0dbba2e
Compare
SE translations |
e280dae
to
07bece5
Compare
07bece5
to
acca3c3
Compare
Can we get some translations for this please 😃 . Will merge in seven days from this comment, regardless of translation state 🤭
|
DE
|
DA |
HE #define TR_DATE_TIME_WIDGET "תאריך ושעה" |
PT
|
IT #define TR_DATE_TIME_WIDGET "Data & Ora" In Italian low (bassa), mid (media) and high (alta) are never related to the state of a battery, but to a position in space. #define TR_LOW_BATT_COLOR "Batteria scarica" |
CN #define TR_DATE_TIME_WIDGET "日期和时间"
#define TR_RADIO_INFO_WIDGET "遥控器信息"
#define TR_LOW_BATT_COLOR "低电量"
#define TR_MID_BATT_COLOR "中电量"
#define TR_HIGH_BATT_COLOR "高电量" TW #define TR_DATE_TIME_WIDGET "日期和時間"
#define TR_RADIO_INFO_WIDGET "遙控器信息"
#define TR_LOW_BATT_COLOR "低電量"
#define TR_MID_BATT_COLOR "中電量"
#define TR_HIGH_BATT_COLOR "高電量" |
CZ #define TR_DATE_TIME_WIDGET "Datum a čas" |
…he radio info widget.
f2f331c
to
0321242
Compare
JP #define TR_DATE_TIME_WIDGET "日付と時刻" |
PL #define TR_DATE_TIME_WIDGET "Data i czas"
#define TR_RADIO_INFO_WIDGET "Informacje o radiu"
#define TR_LOW_BATT_COLOR "Rozładowana bateria"
#define TR_MID_BATT_COLOR "Średni stan baterii"
#define TR_HIGH_BATT_COLOR "Naładowana bateria" |
#define TR_DATE_TIME_WIDGET "Дата и время" |
Allow users to set the low, middle and high battery level colors.
Should these be translatable strings?