Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(color): add color options for radio info widget battery level indicator #4845

Merged
merged 11 commits into from
May 5, 2024

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Apr 6, 2024

Allow users to set the low, middle and high battery level colors.

Should these be translatable strings?

screenshot_tx16s_24-04-06_13-47-53

@froqstar
Copy link

froqstar commented Apr 6, 2024

Looks like we have miles of space there? So for DE:

"Farbe Akku fast leer"
"Farbe Akku mittel"
"Farbe Akku voll"

If there is more space maybe insert a "bei" inbetween "Farbe" and "Akku" for extra clarity.

Could we make the default "full" color depending on the theme secondary foreground (?) color (white in this case)? Green could look ugly with some themes or stick out too much visually when it doesn't need to. Battery full, all good, no need to visually alert the user?

@philmoz
Copy link
Collaborator Author

philmoz commented Apr 6, 2024

I have added translation strings for the widget names and settings.

#define TR_DATE_TIME_WIDGET       "Date & Time"
#define TR_RADIO_INFO_WIDGET      "Radio Info"
#define TR_LOW_BATT_COLOR         "Low battery"
#define TR_MID_BATT_COLOR         "Mid battery"
#define TR_HIGH_BATT_COLOR        "High battery"

@pfeerick pfeerick added enhancement ✨ New feature or request color Related generally to color LCD radios labels Apr 7, 2024
@pfeerick pfeerick added this to the 2.11 milestone Apr 7, 2024
@pfeerick
Copy link
Member

pfeerick commented Apr 7, 2024

Should these be translatable strings?

'fraid so... and sorry for just clobbering this with your other PR 🤪 translations seem to like to always collide

@philmoz philmoz force-pushed the battery-icon-colors branch from 541410c to 0dbba2e Compare April 7, 2024 23:19
@ulfhedlund
Copy link
Contributor

SE translations
#define TR_DATE_TIME_WIDGET "Datum & Tid"
#define TR_RADIO_INFO_WIDGET "Radioinfo" (or if it fits "Radioinformation")
#define TR_LOW_BATT_COLOR "Lågt batteri"
#define TR_MID_BATT_COLOR "Medium batteri"
#define TR_HIGH_BATT_COLOR "Högt batteri"

@philmoz philmoz force-pushed the battery-icon-colors branch from e280dae to 07bece5 Compare April 10, 2024 20:57
@philmoz philmoz force-pushed the battery-icon-colors branch from 07bece5 to acca3c3 Compare April 27, 2024 07:10
@pfeerick
Copy link
Member

pfeerick commented Apr 27, 2024

Can we get some translations for this please 😃 . Will merge in seven days from this comment, regardless of translation state 🤭

#define TR_DATE_TIME_WIDGET       "Date & Time"
#define TR_RADIO_INFO_WIDGET      "Radio Info"
#define TR_LOW_BATT_COLOR         "Low battery"
#define TR_MID_BATT_COLOR         "Mid battery"
#define TR_HIGH_BATT_COLOR        "High battery"

@froqstar
Copy link

DE

#define TR_DATE_TIME_WIDGET       "Datum & Uhrzeit"
#define TR_RADIO_INFO_WIDGET      "Fernst. Info"
#define TR_LOW_BATT_COLOR         "Farbe Akku fast leer"
#define TR_MID_BATT_COLOR         "Farbe Akku mittel"
#define TR_HIGH_BATT_COLOR        "Farbe Akku voll"

@HThuren
Copy link
Contributor

HThuren commented Apr 27, 2024

DA
#define TR_DATE_TIME_WIDGET "Dato & Klokke"
#define TR_RADIO_INFO_WIDGET "Radio info"
#define TR_LOW_BATT_COLOR "Batteri lavt"
#define TR_MID_BATT_COLOR "Batteri medio"
#define TR_HIGH_BATT_COLOR "Batteri højt"

@offer-shmuely
Copy link
Contributor

HE

#define TR_DATE_TIME_WIDGET "תאריך ושעה"
#define TR_RADIO_INFO_WIDGET "מידע השלט"
#define TR_LOW_BATT_COLOR "מתח סוללה נמוך"
#define TR_MID_BATT_COLOR "מתח סוללה בינוני"
#define TR_HIGH_BATT_COLOR "מתח סוללה גבוה"

@zandorsp
Copy link
Contributor

PT

#define TR_DATE_TIME_WIDGET       "Data & Hora"
#define TR_RADIO_INFO_WIDGET      "Inf do Rádio"
#define TR_LOW_BATT_COLOR         "Bateria Baixa"
#define TR_MID_BATT_COLOR         "Bateria Média"
#define TR_HIGH_BATT_COLOR        "Bateria Alta"

@robustini
Copy link
Contributor

IT

#define TR_DATE_TIME_WIDGET "Data & Ora"
#define TR_RADIO_INFO_WIDGET "Radio Info"
#define TR_LOW_BATT_COLOR "Batteria bassa"
#define TR_MID_BATT_COLOR "Batteria media"
#define TR_HIGH_BATT_COLOR "Batteria alta"

In Italian low (bassa), mid (media) and high (alta) are never related to the state of a battery, but to a position in space.
So better alternative for IT:

#define TR_LOW_BATT_COLOR "Batteria scarica"
#define TR_MID_BATT_COLOR "Batteria media"
#define TR_HIGH_BATT_COLOR "Batteria carica"

@zyren
Copy link
Contributor

zyren commented Apr 28, 2024

CN

#define TR_DATE_TIME_WIDGET       "日期和时间"
#define TR_RADIO_INFO_WIDGET      "遥控器信息"
#define TR_LOW_BATT_COLOR         "低电量"
#define TR_MID_BATT_COLOR         "中电量"
#define TR_HIGH_BATT_COLOR        "高电量"

TW

#define TR_DATE_TIME_WIDGET       "日期和時間"
#define TR_RADIO_INFO_WIDGET      "遙控器信息"
#define TR_LOW_BATT_COLOR         "低電量"
#define TR_MID_BATT_COLOR         "中電量"
#define TR_HIGH_BATT_COLOR        "高電量"

@Eldenroot
Copy link
Contributor

CZ

#define TR_DATE_TIME_WIDGET "Datum a čas"
#define TR_RADIO_INFO_WIDGET "Informace o vysílačce"
#define TR_LOW_BATT_COLOR "Vybitá baterie"
#define TR_MID_BATT_COLOR "Středně nabitá baterie"
#define TR_HIGH_BATT_COLOR "Plně nabitá baterie"

@philmoz philmoz force-pushed the battery-icon-colors branch from f2f331c to 0321242 Compare May 3, 2024 22:44
@ToshihiroMakuuchi
Copy link
Contributor

JP

#define TR_DATE_TIME_WIDGET "日付と時刻"
#define TR_RADIO_INFO_WIDGET "送信機情報"
#define TR_LOW_BATT_COLOR "バッテリー低"
#define TR_MID_BATT_COLOR "バッテリー中"
#define TR_HIGH_BATT_COLOR "バッテリー高"

@ajjjjjjjj
Copy link
Contributor

PL

#define TR_DATE_TIME_WIDGET       "Data i czas"
#define TR_RADIO_INFO_WIDGET      "Informacje o radiu"
#define TR_LOW_BATT_COLOR         "Rozładowana bateria"
#define TR_MID_BATT_COLOR         "Średni stan baterii"
#define TR_HIGH_BATT_COLOR        "Naładowana bateria"

@pfeerick pfeerick changed the title feat(color): add color properties for the battery level indicator in the radio info widget. feat(color): add color options for radio info widget battery level indicator May 5, 2024
@pfeerick pfeerick merged commit dd9a620 into EdgeTX:main May 5, 2024
44 checks passed
@kobakirill
Copy link
Contributor

#define TR_DATE_TIME_WIDGET "Дата и время"
#define TR_RADIO_INFO_WIDGET "Инфо о пульте"
#define TR_LOW_BATT_COLOR "Разряженная АКБ"
#define TR_MID_BATT_COLOR "Середина АКБ "
#define TR_HIGH_BATT_COLOR "Заряженная АКБ"

pfeerick added a commit that referenced this pull request May 7, 2024
@pfeerick pfeerick mentioned this pull request May 7, 2024
@philmoz philmoz deleted the battery-icon-colors branch July 27, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color Related generally to color LCD radios enhancement ✨ New feature or request needs:translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.