Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cpn): sort custom functions list #4585

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

elecpower
Copy link
Collaborator

Satisfies Companion side of #3591

@elecpower elecpower added enhancement ✨ New feature or request companion Related to the companion software labels Jan 28, 2024
@pfeerick pfeerick changed the title enh(cpn): Sort custom functions list refactor(cpn): Sort custom functions list Feb 3, 2024
@pfeerick pfeerick changed the title refactor(cpn): Sort custom functions list refactor(cpn): sort custom functions list Feb 3, 2024
@pfeerick pfeerick added this to the 2.11 milestone Feb 11, 2024
@elecpower elecpower force-pushed the elecpower/enh-3591-sort-cust-funcs-list branch from 466d177 to 3e1c412 Compare May 27, 2024 11:00
@elecpower elecpower force-pushed the elecpower/enh-3591-sort-cust-funcs-list branch from 3e1c412 to 951814f Compare August 1, 2024 21:28
@elecpower
Copy link
Collaborator Author

@pfeerick no reason this cannot be merged without the radio side is there?

@pfeerick
Copy link
Member

Yes, and no? Didn't we want radio and companion to match (oh wait, maybe this is deserved since Companion gets left behind?) 🤪 Companion lists them mostly in the same order as the radio atm, but radio side is going to be a pain (since we can't just sort it like with Companion 😢 ), so probably better to merge this than leave it in limbo any longer.

@philmoz
Copy link
Collaborator

philmoz commented Aug 12, 2024

One option for the radio is a sorted index table for each language translation.
It would not add much to the firmware size (compared to locale handling), and could potentially be auto-generated.

@pfeerick
Copy link
Member

pfeerick commented Aug 12, 2024

That's the only really viable option I can see, since it's the index we really need sorted (for it to just work for all UIs)... as I think doing the locale sort would have at best only worked on colorlcd? Without a major re-write to how it is SF/GF are handled for that part of the UI, that is 🤕

@pfeerick pfeerick merged commit be0c8a8 into main Aug 13, 2024
3 checks passed
@pfeerick pfeerick deleted the elecpower/enh-3591-sort-cust-funcs-list branch August 13, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
companion Related to the companion software enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants