-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fatfish F16 support (main) #4485
Conversation
bbfad85
to
e3f2f5d
Compare
I have changed the implementation of the VIDEO switching, now only need a single SF to do the job. |
c8cba47
to
c1ea4c1
Compare
@pfeerick I may need some help for companion support |
Code review only, looks ok. If anything, I would have liked the I plan to rebase to remove the conflicts from #5068 and start on the Companion side support either tonight or tomorrow. |
@richardclli Can you double check ccfdad3 is still ok? It is working fine on my handset, but that doesn't really mean much there 🤪 Probably need to make it so 37f60b3 isn't needed... re: options for Companion... is it going to be able to support flysky gimbals, bluetooth, GPS at some point? |
radio/src/targets/horus/hal.h
Outdated
#if defined(PCBX10) && !defined(RADIO_FAMILY_T16) | ||
// Gimbal switch left |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm... TX16S is in that family also.
I also seem mention of someone adding them to the T16... https://www.rcgroups.com/forums/showpost.php?p=43410103&postcount=7698
Perhaps this was just meant to be for the F16, as I assume those GPIOs were needed for something else?
Ok, F16 schematic seems to say SJ is still on PH.15, but SI pin seems to be connected to BAT_STAT on the charge circuit, and probably wasn't able to be assigned another pin?
return; | ||
#if (!defined(LCD_VERTICAL_INVERT) || defined(RADIO_F16)) && !defined(BOOT) | ||
#if defined(RADIO_F16) | ||
if (hardwareOptions.pcbrev > 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richardclli what is behind this? Did they change the screen type from hardware revision to another?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they rotated the screen between prototype and production version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know if it was between prototype or production, but Richard did say the screen was going to be rotated.
… condition not met.
This reverts commit 0a2119a.
Adds support for Fatfish F16. c.f. https://www.fatfishfpv.com/3280-2/
Closes #4484