Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fatfish F16 support (main) #4485

Merged
merged 18 commits into from
Jun 30, 2024
Merged

feat: Fatfish F16 support (main) #4485

merged 18 commits into from
Jun 30, 2024

Conversation

richardclli
Copy link
Collaborator

@richardclli richardclli commented Dec 30, 2023

Adds support for Fatfish F16. c.f. https://www.fatfishfpv.com/3280-2/

image

Closes #4484

@richardclli richardclli added the color Related generally to color LCD radios label Dec 30, 2023
@richardclli richardclli self-assigned this Dec 30, 2023
@richardclli richardclli marked this pull request as draft December 30, 2023 07:08
@richardclli richardclli changed the title feat(F16): Support of Fatfish F16 feat(F16): Fatfish F16 Support Jan 16, 2024
@richardclli richardclli marked this pull request as ready for review January 16, 2024 02:58
@pfeerick pfeerick added this to the 2.11 milestone Jan 24, 2024
@richardclli richardclli force-pushed the ff_f16 branch 3 times, most recently from bbfad85 to e3f2f5d Compare May 25, 2024 05:27
@richardclli
Copy link
Collaborator Author

I have changed the implementation of the VIDEO switching, now only need a single SF to do the job.
@pfeerick please review.

@richardclli richardclli force-pushed the ff_f16 branch 4 times, most recently from c8cba47 to c1ea4c1 Compare June 1, 2024 04:19
@richardclli
Copy link
Collaborator Author

@pfeerick I may need some help for companion support

@pfeerick pfeerick changed the title feat(F16): Fatfish F16 Support feat: Fatfish F16 support Jun 1, 2024
@pfeerick pfeerick self-assigned this Jun 2, 2024
@pfeerick
Copy link
Member

pfeerick commented Jun 4, 2024

Code review only, looks ok. If anything, I would have liked the lcd_driver changes to have been more generic rather than radio define specific ;)

I plan to rebase to remove the conflicts from #5068 and start on the Companion side support either tonight or tomorrow.

@pfeerick
Copy link
Member

pfeerick commented Jun 4, 2024

@richardclli Can you double check ccfdad3 is still ok? It is working fine on my handset, but that doesn't really mean much there 🤪

Probably need to make it so 37f60b3 isn't needed... simu target can't find those two functions ... but it seems like libsimulator is fine 🤪

re: options for Companion... is it going to be able to support flysky gimbals, bluetooth, GPS at some point?

Comment on lines 248 to 245
#if defined(PCBX10) && !defined(RADIO_FAMILY_T16)
// Gimbal switch left
Copy link
Member

@pfeerick pfeerick Jun 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... TX16S is in that family also.

image

I also seem mention of someone adding them to the T16... https://www.rcgroups.com/forums/showpost.php?p=43410103&postcount=7698

Perhaps this was just meant to be for the F16, as I assume those GPIOs were needed for something else?

Ok, F16 schematic seems to say SJ is still on PH.15, but SI pin seems to be connected to BAT_STAT on the charge circuit, and probably wasn't able to be assigned another pin?

return;
#if (!defined(LCD_VERTICAL_INVERT) || defined(RADIO_F16)) && !defined(BOOT)
#if defined(RADIO_F16)
if (hardwareOptions.pcbrev > 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardclli what is behind this? Did they change the screen type from hardware revision to another?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they rotated the screen between prototype and production version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if it was between prototype or production, but Richard did say the screen was going to be rotated.

@pfeerick pfeerick changed the title feat: Fatfish F16 support feat: Fatfish F16 support (main) Jun 28, 2024
@pfeerick pfeerick modified the milestones: 2.10.2, 2.11 Jun 28, 2024
@pfeerick pfeerick merged commit 961c757 into main Jun 30, 2024
49 checks passed
@pfeerick pfeerick deleted the ff_f16 branch June 30, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color Related generally to color LCD radios hardware support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatfish F16 Radio Support
5 participants