Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use the CMake way for linker options #4396

Merged
merged 2 commits into from
Dec 13, 2023
Merged

chore: Use the CMake way for linker options #4396

merged 2 commits into from
Dec 13, 2023

Conversation

raphaelcoeffic
Copy link
Member

@raphaelcoeffic raphaelcoeffic commented Dec 9, 2023 •
edited
Loading

And fix an issue with the SDRAM start address not being used properly in the bootloader linker command.

@raphaelcoeffic
chores: use the CMake way for linker options
bcbbcc4 
And fix and issue with the SDRAM start address not being used properly in the bootloader linker command.
@TheIsotopes
Copy link
Contributor

Unfortunately, this does not solve issue #4385.
I thought something was coming now.

@raphaelcoeffic
Copy link
Member Author

Unfortunately, this does not solve issue #4385.
I thought something was coming now.

Makes sense, it is aimed at fixing some totally different issue: PL18 / EL18 bootloader not starting (due to wrong SDRAM address).

@richardclli
Copy link
Collaborator

PL18 works, I believed that El18 should works as well.

@richardclli
Copy link
Collaborator

@raphaelcoeffic Seems the PR misses the parameter to override the SDRAM size definition.

@pfeerick
Copy link
Member

pfeerick commented Dec 10, 2023 •
edited
Loading

  • EL18 bootloader and firmware starts up fine after DFU flashing this (whereas nightly bootloader crashes the radio).
  • X9D+
  • TX16S
  • T20
  • LR3
  • MT12

Commando8 does not boot the main firmware properly with this PR or nightly, so something broke for it somewhere between now and Oct-27 (that's the last build I flashed on it ... for #3870).

@pfeerick pfeerick added bug 🪲 Something isn't working compilation Related to compiling the firmware and firmware options labels Dec 10, 2023
@pfeerick pfeerick mentioned this pull request Dec 11, 2023
Merged
@richardclli
Copy link
Collaborator

@raphaelcoeffic I added the SDRAM size definition support based on your scripts.

@pfeerick pfeerick added this to the 2.10 milestone Dec 12, 2023
@pfeerick pfeerick changed the title chores: use the CMake way for linker options chore: Use the CMake way for linker options Dec 12, 2023
@raphaelcoeffic
Copy link
Member Author

@raphaelcoeffic I added the SDRAM size definition support based on your scripts.

Thx! Looks good to me!

@pfeerick pfeerick merged commit 42e245b into main Dec 13, 2023
39 checks passed
@pfeerick pfeerick mentioned this pull request Dec 14, 2023
Closed
1 task
@raphaelcoeffic raphaelcoeffic deleted the fix-bootloader-linker branch March 29, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🪲 Something isn't working compilation Related to compiling the firmware and firmware options
Projects
None yet
Milestone
2.10
Development

Successfully merging this pull request may close these issues.
4 participants
@raphaelcoeffic @TheIsotopes @richardclli @pfeerick