revert(color): LVGL back to v8.2

[philmoz]

Adding this so it doesn't get forgotten.

With the performance issues in LVGL 8.3 it may be necessary to revert back to 8.2.

Rollback of

• perf: LVGL 8.3 #3279
• fix(color): Crash in theme editor #4296
• fix(color): Theme change not updating all colors #4298

Re-add

• fix(simu): Crash in simulator. #4280

[pfeerick]

Looks like more is needed as the UI is somewhat messed up now... but this does need to happen and 8.3 or later can be revisited in the next cycle.

https://github.com/EdgeTX/edgetx/commits/revert-lvgl83/ is more or less a straight reversion of the three merge commits, and it seems when I look at the changes to main vs PR there are several changes that weren't rolled back in etx_lv_theme.cpp =>
https://github.com/EdgeTX/edgetx/compare/revert-lvgl83

[philmoz]

I've fixed the UI issues in this PR.

The other un-reverted changes are:

• etx_lv_theme.cpp - startup initialisation to ensure styles exists early
• lcd_driver.cpp - top down VS bottom up refresh

The lcd_driver.cpp change can be reverted if you want; but it works either way as far as I can see.

[pfeerick]

No, that should be fine to stay, if anything its prep for the next attempt :)

…

On Fri, 24 Nov 2023, 11:36 am philmoz, ***@***.***> wrote: I've fixed the UI issues in this PR. The other un-reverted changes are: - etx_lv_theme.cpp - startup initialisation to ensure styles exists early - lcd_driver.cpp - top down VS bottom up refresh The lcd_driver.cpp change can be reverted if you want; but it works either way as far as I can see. — Reply to this email directly, view it on GitHub <#4337 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJ66KLF53742WZJ25Y3WDDYF723XAVCNFSM6AAAAAA7ROEAB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRVGA2DQNBSGI> . You are receiving this because you commented.Message ID: ***@***.***>