feat(cpn): Extend Log Viewer x-axis time format to show milliseconds #4276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeerick
changed the title
pfeerick
changed the title
pfeerick
changed the title
|
why the "don't merge" label? |
|
Because you're touching companion... Don't you remember there is a no-touch policy in place atm? 😛 |
|
Now that you mention it I vaguely remember Neil working on some stuff ... |
mha1
force-pushed
the
PR_CPN_logviewer_milliseconds
branch
from
121cc49 to
066cb29
Compare
|
Sorry Michael but some bad news in that #4270 breaks this one. qCustomplot upgrade required changes here |
|
Don't worry, I'll wait for your PR to be merged and try again |
|
@mha1 You should be right to rebase and/or try again |
mha1
force-pushed
the
PR_CPN_logviewer_milliseconds
branch
from
066cb29 to
e74b0b5
Compare
rebase done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes: