Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpn): Default calibration values for 6POS switch. #4271

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Oct 31, 2023

When creating a new configuration in Companion the default calibration values do not work for the 6POS switches.

This PR sets better default values (taken from my TX16S) and fixes the values when loading a .etx file if they are set to the old default.

Fixes #4269

@pfeerick pfeerick added bug 🪲 Something isn't working companion Related to the companion software don't merge labels Oct 31, 2023
@pfeerick pfeerick added this to the 2.10 milestone Oct 31, 2023
@philmoz
Copy link
Collaborator Author

philmoz commented Oct 31, 2023

Fixes #4269

Might be worth adding the 2.9.2 as well as 2.10.

@pfeerick pfeerick modified the milestones: 2.10, 2.9.2 Nov 10, 2023
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed... it's a much appreciated QoL improvement.

@pfeerick pfeerick merged commit 33fd679 into EdgeTX:main Nov 10, 2023
MRC3742 pushed a commit to MRC3742/edgetx that referenced this pull request Dec 22, 2023
@philmoz philmoz deleted the fix-cpn-6pos-calib branch February 3, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working companion Related to the companion software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 positions switch on EdgeTX Companion simulator not work
2 participants