-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tts): DE - value 1 representation ("eins", "eine", "ein") #4259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code cleanup, harmonized with tts_en
pfeerick
added a commit
to EdgeTX/edgetx-sdcard-sounds
that referenced
this pull request
Oct 28, 2023
Partner for EdgeTX/edgetx#4259
Like the cross-referenced commit? note: I didn't use the phrase you gave for |
pfeerick
added
bug 🪲
Something isn't working
telemetry 📶
sound 🔉
Related to generated or played audio/sound
translation
labels
Oct 28, 2023
stupid copy/paste dbm0.wav - ok km, dbm, rpm, mph using your new .wav's tested ok with this PR. Thank you very much! |
pfeerick
added a commit
to EdgeTX/edgetx-sdcard-sounds
that referenced
this pull request
Oct 28, 2023
Mea culpa... even worse than that... I even typed it in English for the source text, and the penny didn't drop 🤪 |
all good now |
pfeerick
pushed a commit
that referenced
this pull request
Oct 29, 2023
MRC3742
pushed a commit
to MRC3742/edgetx
that referenced
this pull request
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🪲
Something isn't working
rn: warning
Warning needed in release notes
sound 🔉
Related to generated or played audio/sound
telemetry 📶
translation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handles DE language quirk for values of exactly 1 and 1.0 properly for all different scenarios:
Note: there are also some minor issues with the DE sound pack which need fixing for km, dbm, rpm and mph to work properly. Code is prepared to handle those units and will work correctly as soon as the DE sound pack is updated.
@pfeerick: I found more quirks and also DE sound pack issues worth fixing and have done extensive testing on this update, especially going through all units, critical cases (e.g. 0, 0,9, 1.0, 1,1), negative values, small and big numbers. I'd very much appreciate this also going into 2.9.2 knowing km, dbm, rpm and mph will not work properly (unit messages omitted) until the DE sound pack update
Sorry for the inconvenience!