Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tts): DE - value 1 representation ("eins", "eine", "ein") #4259

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

mha1
Copy link
Contributor

@mha1 mha1 commented Oct 28, 2023

handles DE language quirk for values of exactly 1 and 1.0 properly for all different scenarios:

  • units: handles no unit, just singular unit (e.g. Volt), plural units (e.g. Sekunde, Sekunden) also for the odd DE exception to the rule (e.g. rad - "ein Radiant", not "eine" Radiant compared to "eine Stunde")
  • fractions: handling special case 1.0

Note: there are also some minor issues with the DE sound pack which need fixing for km, dbm, rpm and mph to work properly. Code is prepared to handle those units and will work correctly as soon as the DE sound pack is updated.

  • km0.wav ("Kilometer") and dbm0.wav ("DBM") are missing
  • rpm requires rpm0.wav ("Umdrehung pro Minute") and rpm1.wav ("Umdrehungen pro Minute")
  • mph requires mph0.wav ("Meile pro Stunde") and mph1.wav ("Meilen pro Stunde")

@pfeerick: I found more quirks and also DE sound pack issues worth fixing and have done extensive testing on this update, especially going through all units, critical cases (e.g. 0, 0,9, 1.0, 1,1), negative values, small and big numbers. I'd very much appreciate this also going into 2.9.2 knowing km, dbm, rpm and mph will not work properly (unit messages omitted) until the DE sound pack update

Sorry for the inconvenience!

code cleanup, harmonized with tts_en
pfeerick added a commit to EdgeTX/edgetx-sdcard-sounds that referenced this pull request Oct 28, 2023
@pfeerick
Copy link
Member

Like the cross-referenced commit? note: I didn't use the phrase you gave for mph1.wav 🤣

@pfeerick pfeerick added bug 🪲 Something isn't working telemetry 📶 sound 🔉 Related to generated or played audio/sound translation labels Oct 28, 2023
@pfeerick pfeerick added this to the 2.9.2 milestone Oct 28, 2023
@mha1
Copy link
Contributor Author

mha1 commented Oct 28, 2023

stupid copy/paste

dbm0.wav - ok
km0.wav -ok
mph0.wav - ok
mph1.wav - ok
rpm0.wav - ok
rpm1.wav - ok

km, dbm, rpm, mph using your new .wav's tested ok with this PR. Thank you very much!

@mha1
Copy link
Contributor Author

mha1 commented Oct 28, 2023

image

edit: mph not ok. copy/paste was worse than assumed. It's miles per hours not minutes

please change to
mph0.wav ("Meile pro Stunde") and mph1.wav ("Meilen pro Stunde")

pfeerick added a commit to EdgeTX/edgetx-sdcard-sounds that referenced this pull request Oct 28, 2023
@pfeerick
Copy link
Member

Mea culpa... even worse than that... I even typed it in English for the source text, and the penny didn't drop 🤪

@mha1 mha1 marked this pull request as draft October 29, 2023 05:59
@mha1
Copy link
Contributor Author

mha1 commented Oct 29, 2023

all good now

@mha1 mha1 marked this pull request as ready for review October 29, 2023 08:26
@pfeerick pfeerick added the rn: warning Warning needed in release notes label Oct 29, 2023
@pfeerick pfeerick merged commit 9392204 into EdgeTX:main Oct 29, 2023
@pfeerick pfeerick deleted the PR_update_tts_DE branch October 29, 2023 08:32
MRC3742 pushed a commit to MRC3742/edgetx that referenced this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working rn: warning Warning needed in release notes sound 🔉 Related to generated or played audio/sound telemetry 📶 translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants