-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(color): Refreshing of GPS and DATE_TIME telemetry when using Value Widget #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes refresh of GPS and DATETIME values on Value Widget (color)
frankiearzu
changed the title
fix (color) Fix refrehing of GPS and DATE_TIME values on Value-Widget.
fix (color) Fix refrehing of GPS and DATE_TIME telemetry values when using Value-Widget.
Oct 26, 2023
Fantastic! :) Yes, YYYY-MM-DD makes more sense to me, as you can straight away work out the year, and hopefully then figure out it's MM-DD after that. |
pfeerick
added
bug 🪲
Something isn't working
color
Related generally to color LCD radios
widget
telemetry 📶
labels
Oct 27, 2023
pfeerick
changed the title
fix (color) Fix refrehing of GPS and DATE_TIME telemetry values when using Value-Widget.
fix (color): Refreshing of GPS and DATE_TIME telemetry when using Value Widget
Oct 27, 2023
pfeerick
changed the title
fix (color): Refreshing of GPS and DATE_TIME telemetry when using Value Widget
fix(color): Refreshing of GPS and DATE_TIME telemetry when using Value Widget
Oct 27, 2023
pfeerick
pushed a commit
that referenced
this pull request
Nov 5, 2023
This was referenced Dec 19, 2023
MRC3742
pushed a commit
to MRC3742/edgetx
that referenced
this pull request
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4170
Summary of changes:
With data-types who are not plain 32bit numbers, like GPS, Text, DATE_TIME, we have to populate the telemetry "value" with something that changes so that the "value" widget detects the change. The trick is to populate the "value" with a hash of the GPS or DATE_TIME complex value. The actual value for GPS and DateTime are stored in different variables.
The "value" widget was not displaying correctly DATE_TIME, fixed it (don't know why was moving the x coordinate -42 pixels!).
Change dateTime format to ISO 8601 date for color radios (YYYY-MM-DD HH:MM:SS).
NOTE: B&W was already this format (with 4 digits for year), and sensor log writing too... good for consistency.
NOT COMPILED FOR PRODUCTION: Updated Spektrun GPS testing code to change the values for GPS coordinates and Date without having the physical sensor (used previously captured data).
NOTE: Same PR worked for 2.9.1 as well as Main.