Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cpn): Jumper T20 support #4227

Merged
merged 7 commits into from
Oct 24, 2023
Merged

feat(cpn): Jumper T20 support #4227

merged 7 commits into from
Oct 24, 2023

Conversation

3djc
Copy link
Collaborator

@3djc 3djc commented Oct 20, 2023

This adds support for T20 model editing in Companion (no simulator)

Initial work by @pfeerick

This fixes #4233

@elecpower
Copy link
Collaborator

Compiler warnings that require attention:
/src/edgetx/companion/src/modeledit/flightmode.ui: Warning: The name 'verticalLayout_4' (QVBoxLayout) is already in use, defaulting to 'verticalLayout_41'.
/src/edgetx/companion/src/modeledit/flightmode.ui: Warning: The name 'verticalSpacer_2' (QSpacerItem) is already in use, defaulting to 'verticalSpacer_21'.
/src/edgetx/companion/src/modeledit/flightmode.ui: Warning: The name 'verticalLayout_5' (QVBoxLayout) is already in use, defaulting to 'verticalLayout_51'.
/src/edgetx/companion/src/modeledit/flightmode.ui: Warning: The name 'verticalSpacer' (QSpacerItem) is already in use, defaulting to 'verticalSpacer1'.

@pfeerick pfeerick added the companion Related to the companion software label Oct 23, 2023
@pfeerick pfeerick added this to the 2.10 milestone Oct 23, 2023
@pfeerick
Copy link
Member

pfeerick commented Oct 23, 2023

Might want to do something about this... firmware may also need some TLC also though, as Trm7/T7 & Trm8/T8 don't appear as an available mix source there either (on a firmware build from mid-September), although all eight are present in the flight modes.

image

edit: btw, I just disabled the companion simulator plugin building, as I don't think we really want this until it's ready 🤭

image

... plus, it ends in as a weird 9X frankensimu
@3djc
Copy link
Collaborator Author

3djc commented Oct 23, 2023

Opened an issue to make sure I don't forget

@pfeerick pfeerick changed the title T20 companion support feat(cpn): T20 support Oct 24, 2023
@pfeerick pfeerick changed the title feat(cpn): T20 support feat(cpn): Jumper T20 support Oct 24, 2023
@pfeerick pfeerick merged commit a467d2c into main Oct 24, 2023
40 checks passed
@pfeerick pfeerick deleted the cpn-t20 branch October 24, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
companion Related to the companion software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

T20: T7/T8 missing as source
3 participants