Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

fix(ios): FirebaseCrashlytics release mode and delegate handling improvements #1714

Conversation

NathanWalker
Copy link
Contributor

  • fixes FirebaseCrashlytics import in release mode (see attachments) - When building in release mode for store upload the module import would cause error
  • improves delegate handling to retain on the firebase symbol to avoid occasional early garbage collection by v8 engine
  • fixes random crash when trying to login with Google on iOS with {N} 7

This is published under rc right now with @nativescript/firebase 11.1.1-rc.0 if anyone experiences issues related to above can try and please confirm here if it solved it for you.

Screen Shot 2020-11-01 at 8 16 35 AM

@romandrahan
Copy link

romandrahan commented Nov 2, 2020

It looks like #1640 (comment) has been resolved here 👍

@EddyVerbruggen
Copy link
Owner

Ah, nice, I missed this PR and fixed that first issue in the same way :)
Merging! Thank you @NathanWalker!

Copy link
Collaborator

@lambourn lambourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: the semicolon causes a warning when main.m gets processed

warning: extra tokens at end of #import directive [-Wextra-tokens]
#import <FirebaseCrashlytics/FirebaseCrashlytics.h>;

@EddyVerbruggen
Copy link
Owner

@lambourn lol, that's probably why Github says there's a merge conflict on that line :)

EddyVerbruggen added a commit that referenced this pull request Nov 2, 2020
…ovements #1714 - resolve merge conflict (will revert)
@EddyVerbruggen EddyVerbruggen merged commit e253bc8 into EddyVerbruggen:master Nov 2, 2020
@EddyVerbruggen EddyVerbruggen added this to the 11.1.1 milestone Nov 2, 2020
EddyVerbruggen added a commit that referenced this pull request Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants