Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nifty asset lint #5

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

febo
Copy link

@febo febo commented Aug 6, 2024

This PR fixes lint errors on Nifty Asset pages. It also bumps the package to the latest 0.6.1 version.

@dlin128
Copy link
Member

dlin128 commented Aug 6, 2024

pnpm build  

> [email protected] build /Users/dlin/Developer/explorer/temp/explorer
> next build

  ▲ Next.js 14.2.5
  - Experiments (use with caution):
    · missingSuspenseWithCSRBailout

   Creating an optimized production build ...
<w> [webpack.cache.PackFileCacheStrategy] Skipped not serializable cache item 'Compilation/modules|/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/build/webpack/loaders/css-loader/src/index.js??ruleSet[1].rules[13].oneOf[13].use[2]!/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/build/webpack/loaders/postcss-loader/src/index.js??ruleSet[1].rules[13].oneOf[13].use[3]!/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/build/webpack/loaders/resolve-url-loader/index.js??ruleSet[1].rules[13].oneOf[13].use[4]!/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/sass-loader/cjs.js??ruleSet[1].rules[13].oneOf[13].use[5]!/Users/dlin/Developer/explorer/temp/explorer/app/scss/theme-dark.scss': No serializer registered for SassError
<w> while serializing webpack/lib/cache/PackFileCacheStrategy.PackContentItems -> webpack/lib/NormalModule -> webpack/lib/ModuleBuildError -> SassError
Failed to compile.

./app/scss/theme-dark.scss.webpack[javascript/auto]!=!./node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/build/webpack/loaders/css-loader/src/index.js??ruleSet[1].rules[13].oneOf[13].use[2]!./node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/build/webpack/loaders/postcss-loader/src/index.js??ruleSet[1].rules[13].oneOf[13].use[3]!./node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/build/webpack/loaders/resolve-url-loader/index.js??ruleSet[1].rules[13].oneOf[13].use[4]!./node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/sass-loader/cjs.js??ruleSet[1].rules[13].oneOf[13].use[5]!./app/scss/theme-dark.scss
SassError: Undefined mixin.
   ╷
22 │ ┌         @include alert-variant(
23 │ │             shift-color($value, $alert-bg-scale),
24 │ │             shift-color($value, $alert-border-scale),
25 │ │             color-contrast(shift-color($value, $alert-bg-scale))
26 │ │         );
   │ └─────────^
   ╵
  app/scss/dashkit/_alert.scss 22:9  @import
  app/scss/dashkit/_theme.scss 19:9  @import
  app/scss/theme-dark.scss 29:9      root stylesheet

Import trace for requested module:
./app/scss/theme-dark.scss.webpack[javascript/auto]!=!./node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/build/webpack/loaders/css-loader/src/index.js??ruleSet[1].rules[13].oneOf[13].use[2]!./node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/build/webpack/loaders/postcss-loader/src/index.js??ruleSet[1].rules[13].oneOf[13].use[3]!./node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/build/webpack/loaders/resolve-url-loader/index.js??ruleSet[1].rules[13].oneOf[13].use[4]!./node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/sass-loader/cjs.js??ruleSet[1].rules[13].oneOf[13].use[5]!./app/scss/theme-dark.scss
./app/scss/theme-dark.scss

./app/scss/theme-dark.scss
SassError: Undefined mixin.
   ╷
22 │ ┌         @include alert-variant(
23 │ │             shift-color($value, $alert-bg-scale),
24 │ │             shift-color($value, $alert-border-scale),
25 │ │             color-contrast(shift-color($value, $alert-bg-scale))
26 │ │         );
   │ └─────────^
   ╵
  app/scss/dashkit/_alert.scss 22:9  @import
  app/scss/dashkit/_theme.scss 19:9  @import
  app/scss/theme-dark.scss 29:9      root stylesheet
    at tryRunOrWebpackError (/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/webpack/bundle5.js:28:312989)
    at __webpack_require_module__ (/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/webpack/bundle5.js:28:131165)
    at __nested_webpack_require_153728__ (/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/webpack/bundle5.js:28:130607)
    at /Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/webpack/bundle5.js:28:131454
    at symbolIterator (/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/neo-async/async.js:1:14444)
    at done (/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/neo-async/async.js:1:14824)
    at Hook.eval [as callAsync] (eval at create (/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/webpack/bundle5.js:13:28858), <anonymous>:15:1)
    at /Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/webpack/bundle5.js:28:130328
    at symbolIterator (/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/neo-async/async.js:1:14402)
    at timesSync (/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/neo-async/async.js:1:5027)
-- inner error --
SassError: Undefined mixin.
   ╷
22 │ ┌         @include alert-variant(
23 │ │             shift-color($value, $alert-bg-scale),
24 │ │             shift-color($value, $alert-border-scale),
25 │ │             color-contrast(shift-color($value, $alert-bg-scale))
26 │ │         );
   │ └─────────^
   ╵
  app/scss/dashkit/_alert.scss 22:9  @import
  app/scss/dashkit/_theme.scss 19:9  @import
  app/scss/theme-dark.scss 29:9      root stylesheet
    at Object.<anonymous> (/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/build/webpack/loaders/css-loader/src/index.js??ruleSet[1].rules[13].oneOf[13].use[2]!/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/build/webpack/loaders/postcss-loader/src/index.js??ruleSet[1].rules[13].oneOf[13].use[3]!/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/build/webpack/loaders/resolve-url-loader/index.js??ruleSet[1].rules[13].oneOf[13].use[4]!/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/sass-loader/cjs.js??ruleSet[1].rules[13].oneOf[13].use[5]!/Users/dlin/Developer/explorer/temp/explorer/app/scss/theme-dark.scss:1:7)
    at /Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/webpack/bundle5.js:28:922493
    at Hook.eval [as call] (eval at create (/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/webpack/bundle5.js:13:28636), <anonymous>:7:1)
    at /Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/webpack/bundle5.js:28:131198
    at tryRunOrWebpackError (/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/webpack/bundle5.js:28:312943)
    at __webpack_require_module__ (/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/webpack/bundle5.js:28:131165)
    at __nested_webpack_require_153728__ (/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/webpack/bundle5.js:28:130607)
    at /Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/webpack/bundle5.js:28:131454
    at symbolIterator (/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/neo-async/async.js:1:14444)
    at done (/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/neo-async/async.js:1:14824)

Generated code for /Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/build/webpack/loaders/css-loader/src/index.js??ruleSet[1].rules[13].oneOf[13].use[2]!/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/build/webpack/loaders/postcss-loader/src/index.js??ruleSet[1].rules[13].oneOf[13].use[3]!/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/build/webpack/loaders/resolve-url-loader/index.js??ruleSet[1].rules[13].oneOf[13].use[4]!/Users/dlin/Developer/explorer/temp/explorer/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected][email protected]/node_modules/next/dist/compiled/sass-loader/cjs.js??ruleSet[1].rules[13].oneOf[13].use[5]!/Users/dlin/Developer/explorer/temp/explorer/app/scss/theme-dark.scss

Import trace for requested module:
./app/scss/theme-dark.scss


> Build failed because of webpack errors
 ELIFECYCLE  Command failed with exit code 1.

@dlin128
Copy link
Member

dlin128 commented Aug 6, 2024

Nevermind i messed up my local env. Builds fine now!

Copy link
Member

@dlin128 dlin128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dlin128 dlin128 merged commit 06e067b into Eclipse-Laboratories-Inc:eclipse_devnet Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants