Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of axiomatized by in favor of [opaque] with trivial lemma #681

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

oskgo
Copy link
Contributor

@oskgo oskgo commented Jan 10, 2025

Note that this does not fully deprecate axiomatized by yet. It only removes its uses from the stdlib.

Ref: #94

@strub strub added the chore Ungrateful tasks that need done but that nobody wants to do label Jan 10, 2025
@strub strub self-assigned this Jan 10, 2025
@strub strub enabled auto-merge (rebase) January 10, 2025 13:47
@oskgo
Copy link
Contributor Author

oskgo commented Jan 10, 2025

I can't check examples/MEE-CBC/FunctionalSpec.ec locally. CBC doesn't find FMap for some reason. Any idea about this?

I'll make the fixes anyways and use CI to check them instead though.

@strub
Copy link
Member

strub commented Jan 10, 2025

With make check?

auto-merge was automatically disabled January 10, 2025 14:11

Head branch was pushed to by a user without write access

@oskgo oskgo force-pushed the purge-axiomatized-by branch from 300959a to 9b62db2 Compare January 10, 2025 14:11
@oskgo
Copy link
Contributor Author

oskgo commented Jan 10, 2025

make check is picking up a lot of errors from emacs temp files and won't get to the examples, but I'll try to get it working.

@strub
Copy link
Member

strub commented Jan 10, 2025

make check is picking up a lot of errors from emacs temp files and won't get to the examples, but I'll try to get it working.

This should not be the case. Could you file an issue with more details?

@oskgo oskgo force-pushed the purge-axiomatized-by branch from 9b62db2 to 4c64606 Compare January 10, 2025 14:38
@oskgo
Copy link
Contributor Author

oskgo commented Jan 10, 2025

Using make check seems to work once I've removed all the .#Theory.ec files, but I'd like to note that the developer experience of having to re-check every single theory for a single fix in a single file is not great. Is there something I'm doing wrong or is this just how the stdlib works?

@strub
Copy link
Member

strub commented Jan 10, 2025

That's sub-optimal, I agree. This is because make check disables .eco generation. But we should change this.

@strub strub merged commit 4f84b7c into EasyCrypt:main Jan 10, 2025
15 checks passed
@oskgo oskgo deleted the purge-axiomatized-by branch January 10, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Ungrateful tasks that need done but that nobody wants to do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants