-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rigid unification option for hint solve/exact
#680
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustavo2622
force-pushed
the
irreducible-lemmas
branch
2 times, most recently
from
January 10, 2025 18:04
28dffab
to
59acb83
Compare
Gustavo2622
changed the title
Rigid unification option for
Rigid unification option for Jan 10, 2025
hint solve/exact
hint solve/exact
+ print hint
strub
force-pushed
the
irreducible-lemmas
branch
5 times, most recently
from
January 13, 2025 10:15
fa190ad
to
6942ea5
Compare
strub
commented
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add test files & see my comments below.
Gustavo2622
force-pushed
the
irreducible-lemmas
branch
3 times, most recently
from
January 13, 2025 18:40
fa83649
to
addaf91
Compare
Gustavo2622
previously requested changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to transform test files into actual test
strub
force-pushed
the
irreducible-lemmas
branch
2 times, most recently
from
January 14, 2025 07:07
7f4d430
to
b2aa558
Compare
Gustavo2622
force-pushed
the
irreducible-lemmas
branch
from
January 14, 2025 10:51
b2aa558
to
78641c4
Compare
I separated the part for printing hints databases in #689 |
strub
force-pushed
the
irreducible-lemmas
branch
from
January 16, 2025 09:46
78641c4
to
9eaf7fa
Compare
strub
changed the title
Rigid unification option for
Rigid unification option for Jan 16, 2025
hint solve/exact
+ print hinthint solve/exact
Gustavo2622
force-pushed
the
better-print-hints
branch
from
January 16, 2025 18:03
d84e76f
to
5b322a9
Compare
This features introduced a new `rigid` flag for `hint exact/solve`. Lemmas added to a hint with this flag are applied using a rigid unification algorithm. Co-Authored-By: Gustavo Delerue <[email protected]> Co-Authored-By: Pierre-Yves Strub <[email protected]>
strub
force-pushed
the
irreducible-lemmas
branch
from
January 17, 2025 07:54
9eaf7fa
to
10af190
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to disable reduction of the expressions in hint solve/exact.