Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rigid unification option for hint solve/exact #680

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

strub
Copy link
Member

@strub strub commented Jan 10, 2025

Add functionality to disable reduction of the expressions in hint solve/exact.

@Gustavo2622 Gustavo2622 force-pushed the irreducible-lemmas branch 2 times, most recently from 28dffab to 59acb83 Compare January 10, 2025 18:04
@Gustavo2622 Gustavo2622 changed the title Rigid unification option for hint solve/exact Rigid unification option for hint solve/exact + print hint Jan 10, 2025
@strub strub force-pushed the irreducible-lemmas branch 5 times, most recently from fa190ad to 6942ea5 Compare January 13, 2025 10:15
@strub strub marked this pull request as ready for review January 13, 2025 10:16
Copy link
Member Author

@strub strub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add test files & see my comments below.

src/ecCommands.ml Outdated Show resolved Hide resolved
src/ecEnv.ml Outdated Show resolved Hide resolved
src/ecParser.mly Outdated Show resolved Hide resolved
src/ecPrinting.ml Outdated Show resolved Hide resolved
src/ecSection.ml Outdated Show resolved Hide resolved
src/ecParser.mly Outdated Show resolved Hide resolved
@Gustavo2622 Gustavo2622 force-pushed the irreducible-lemmas branch 3 times, most recently from fa83649 to addaf91 Compare January 13, 2025 18:40
Copy link
Contributor

@Gustavo2622 Gustavo2622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to transform test files into actual test

tests/hint_rigid_should_fail_immediate.ec Outdated Show resolved Hide resolved
tests/hint_rigid_should_fail_timeout.ec Outdated Show resolved Hide resolved
@strub strub force-pushed the irreducible-lemmas branch 2 times, most recently from 7f4d430 to b2aa558 Compare January 14, 2025 07:07
@strub
Copy link
Member Author

strub commented Jan 16, 2025

I separated the part for printing hints databases in #689

@strub strub force-pushed the irreducible-lemmas branch from 78641c4 to 9eaf7fa Compare January 16, 2025 09:46
@strub strub changed the title Rigid unification option for hint solve/exact + print hint Rigid unification option for hint solve/exact Jan 16, 2025
@strub strub changed the base branch from main to better-print-hints January 16, 2025 09:46
Base automatically changed from better-print-hints to main January 17, 2025 07:52
This features introduced a new `rigid` flag for `hint
exact/solve`. Lemmas added to a hint with this flag are applied using
a rigid unification algorithm.

Co-Authored-By: Gustavo Delerue <[email protected]>
Co-Authored-By: Pierre-Yves Strub <[email protected]>
@strub strub force-pushed the irreducible-lemmas branch from 9eaf7fa to 10af190 Compare January 17, 2025 07:54
@strub strub merged commit 5f7be80 into main Jan 17, 2025
15 checks passed
@strub strub deleted the irreducible-lemmas branch January 17, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants