fixed reset password for code #4
Conversation
| @@ -276,7 +296,19 @@ protected virtual async Task<string> GenerateCodeAsync(string phoneNumber, Verif | |||
| switch (type) | |||
| { | |||
| case VerificationCodeType.ResetPassword: | |||
| code = await _identityUserManager.GeneratePasswordResetTokenAsync(identityUser); | |||
There was a problem hiding this comment.
Why not use ASP.NET Core's IdentityUserManager.GeneratePasswordResetTokenAsync();? The default implementation of IUserTwoFactorTokenProvider is fine and EasyAbp also provides one: https://github.com/EasyAbp/Abp.VerificationCode/blob/master/src/EasyAbp.Abp.VerificationCode.Identity/EasyAbp/Abp/VerificationCode/Identity/AbpVerificationCodeTokenProvider.cs.
There was a problem hiding this comment.
GeneratePasswordResetTokenAsync() this method generate code length too long , the sms not allow code longer than 24 in aliyun .
There was a problem hiding this comment.
You can replece the default implementation, see https://github.com/EasyAbp/Abp.VerificationCode/blob/master/src/EasyAbp.Abp.VerificationCode.Identity/EasyAbp/Abp/VerificationCode/Identity/AbpVerificationCodeTokenProvider.cs
There was a problem hiding this comment.
the Abp.VerficationCode not implement twoFactor methods yet . I need to take time to fix that repository ,wait some days please when i have time .
| @@ -276,7 +296,19 @@ protected virtual async Task<string> GenerateCodeAsync(string phoneNumber, Verif | |||
| switch (type) | |||
| { | |||
| case VerificationCodeType.ResetPassword: | |||
| code = await _identityUserManager.GeneratePasswordResetTokenAsync(identityUser); | |||
| if (identityUser == null) | |||
| throw new UserFriendlyException(_localizer["InvalidPhoneNumber"]); | |||
There was a problem hiding this comment.
What about throw new InvalidVerificationCodeException();?
There was a problem hiding this comment.
if u used twofactor to generate , u need use identityuser not null , identityuser come from phonenumber in database. database doesn`t have this phonenumber u cant resetpassword.
improve reset password use phone and code use TwoFactor way in generate code and verify code