Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working PETSIRD writer #7

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Working PETSIRD writer #7

merged 6 commits into from
Nov 14, 2023

Conversation

hansenms
Copy link
Contributor

Changes in this pull request

First working version of PETSIRD writer. It produces a valid file, but reconstruction from file is not confirmed.

Testing performed

Manual testing to validate that it runs.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • The code builds and runs on my machine

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in the ETSI software (the Work) under the terms and conditions of the Apache-2.0 License.

@hansenms hansenms requested a review from johnstairs November 14, 2023 21:12
@hansenms hansenms merged commit d728015 into main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstairs johnstairs johnstairs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hansenms @johnstairs